mbox series

[RFC,0/2] Hack for perl module subdirectories

Message ID 20180813175645.11088-1-chrismcc@gmail.com
Headers show
Series Hack for perl module subdirectories | expand

Message

Christopher McCrory Aug. 13, 2018, 5:56 p.m. UTC 
When perl modules have Makefiles in subdirectories, not all of the
arguments to Makefile.PL get propagated to subdirectory/Makefile.PL.
This causes compile failures.  Two examples are template-toolkit and
xml-parser. A hack is to fix them after the usual configure step.
Something like this:

$(SED) "s:^AR = .*:AR = $(TARGET_AR):g" $(@D)/Expat/Makefile

for AR, CC, xFLAGS, etc.  This "works", but there should be a better
way. Hence the RFC.


Also there is a package, libxml-parser-perl, that is a host only perl
xml-parser package needed by host-intltool and metacity.  Should they
stay seprate or be merged?

Christopher McCrory (2):
  perl-template-toolkit: new package
  perl-xml-parser: new package

 DEVELOPERS                                         |  2 ++
 package/Config.in                                  |  2 ++
 package/perl-template-toolkit/Config.in            | 11 ++++++++
 .../perl-template-toolkit.hash                     |  6 ++++
 .../perl-template-toolkit/perl-template-toolkit.mk | 32 ++++++++++++++++++++++
 5 files changed, 53 insertions(+)
 create mode 100644 package/perl-template-toolkit/Config.in
 create mode 100644 package/perl-template-toolkit/perl-template-toolkit.hash
 create mode 100644 package/perl-template-toolkit/perl-template-toolkit.mk

Comments

Thomas Petazzoni Aug. 13, 2018, 9:03 p.m. UTC | #1 
Hello,

On Mon, 13 Aug 2018 10:56:43 -0700, Christopher McCrory wrote:

> for AR, CC, xFLAGS, etc.  This "works", but there should be a better
> way. Hence the RFC.
> 
> Also there is a package, libxml-parser-perl, that is a host only perl
> xml-parser package needed by host-intltool and metacity.  Should they
> stay seprate or be merged?

libxml-parser-perl is intentionally not using the perl-package
infrastructure, because we don't want to require building host-perl to
build host-intltool.

Some libxml-parser-perl is using the system-wide Perl, which is a
mandatory Buildroot dependency.

Perhaps we should add a comment in libxml-parser-perl.mk to explain
this.

Best regards,

Thomas