From patchwork Mon Apr 16 02:29:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos Santos X-Patchwork-Id: 898409 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=datacom.ind.br Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40PXR05Rwfz9s08 for ; Mon, 16 Apr 2018 12:30:04 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1964B8706F; Mon, 16 Apr 2018 02:30:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 49IyZAQHsYSQ; Mon, 16 Apr 2018 02:30:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 62E6186B02; Mon, 16 Apr 2018 02:30:00 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 75FF41C09A7 for ; Mon, 16 Apr 2018 02:29:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 72C7C86D6F for ; Mon, 16 Apr 2018 02:29:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5GrEkJIr7CPA for ; Mon, 16 Apr 2018 02:29:58 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.datacom.ind.br (mx.datacom.ind.br [177.66.5.10]) by whitealder.osuosl.org (Postfix) with ESMTPS id B749A8705D for ; Mon, 16 Apr 2018 02:29:57 +0000 (UTC) Received: from mail.datacom.ind.br (localhost [127.0.0.1]) by mail.datacom.ind.br (Postfix) with ESMTPS id 0D6DE1BA034C; Sun, 15 Apr 2018 23:29:56 -0300 (-03) Received: from localhost (localhost [127.0.0.1]) by mail.datacom.ind.br (Postfix) with ESMTP id E9E141BA0348; Sun, 15 Apr 2018 23:29:55 -0300 (-03) Received: from mail.datacom.ind.br ([127.0.0.1]) by localhost (mail.datacom.ind.br [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WWexT_rBvxj2; Sun, 15 Apr 2018 23:29:55 -0300 (-03) Received: from p7-1130br.casantos.org (unknown [177.18.78.240]) by mail.datacom.ind.br (Postfix) with ESMTPSA id 05B941BA0133; Sun, 15 Apr 2018 23:29:54 -0300 (-03) From: Carlos Santos To: buildroot@buildroot.org Date: Sun, 15 Apr 2018 23:29:18 -0300 Message-Id: <20180416022944.13644-1-casantos@datacom.ind.br> X-Mailer: git-send-email 2.14.3 Subject: [Buildroot] [PATCH 00/26] init scripts: don't test if binaries exist X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernd Kuhls , John Stile , Aleksander Morgado , Simon Dawson , Eric Le Bihan , Dushara Jayasinghe , "Yann E . MORIN" MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" As discussed in the mailing list, it is useless to test if a binary file exists and/or is executable. Buildroot installs both the executable files and their init scripts as part of the same packages. But if it ever happens for some reason, the error message from start-stop-daemon or from the shell should be pretty clear. If a variable containing the file name existed (e.g. DAEMON) and was used only once it was replaced by the full path of the binary file. Unused variables resulting from these simplifications were removed too. Carlos Santos (26): bind: don't test if the binary exists in the init script dbus: don't test if the binary exists in the init script dhcpcd: don't test if the binary exists in the init script dmraid: don't test if the binary exists in the init script dnsmasq: don't test if the binary exists in the init script eudev: don't test if the binary exists in the init script haveged: don't test if the binary exists in the init script modem-manager: don't test if the binary exists in the init script mpd: don't test if the binary exists in the init script neard: don't test if the binary exists in the init script netplug: don't test if the binary exists in the init script netsnmp: don't test if the binaries exist in the init script network-manager: don't test if the binary exists in the init script nfs-utils: don't test if the binary exists in the init script ntp: don't test if the binary exists in the init script openntpd: don't test if the binary exists in the init script openvpn: don't test if the binary exists in the init script proftpd: don't test if the binary exists in the init script prosody: don't test if the binary exists in the init script squid: don't test if the binary exists in the init script tinyhttpd: don't test if the binary exists in the init script tpm2-abrmd: don't test if the binary exists in the init script transmission: don't test if the binary exists in the init script triggerhappy: don't test if the binary exists in the init script tvheadend: don't test if the binary exists in the init script upmpdcli: don't test if the binary exists in the init script package/bind/S81named | 1 - package/dbus/S30dbus | 3 --- package/dhcpcd/S41dhcpcd | 1 - package/dmraid/S20dmraid | 2 -- package/dnsmasq/S80dnsmasq | 1 - package/eudev/S10udev | 6 +----- package/haveged/S21haveged | 2 -- package/modem-manager/S44modem-manager | 2 -- package/mpd/S95mpd | 1 - package/neard/S53neard | 6 +----- package/netplug/S29netplug | 2 -- package/netsnmp/S59snmpd | 3 --- package/network-manager/S45network-manager | 10 +--------- package/nfs-utils/S60nfs | 5 ----- package/ntp/S49ntp | 6 +----- package/openntpd/S49ntp | 1 - package/openvpn/S60openvpn | 6 +----- package/proftpd/S50proftpd | 4 +--- package/prosody/S50prosody | 6 +----- package/squid/S97squid | 1 - package/tinyhttpd/S85tinyhttpd | 1 - package/tpm2-abrmd/S80tpm2-abrmd | 8 ++------ package/transmission/S92transmission | 3 --- package/triggerhappy/S10triggerhappy | 6 +----- package/tvheadend/S99tvheadend | 5 +---- package/upmpdcli/S99upmpdcli | 6 +----- 26 files changed, 12 insertions(+), 86 deletions(-) Reviewed-by: Petr Vorel