[v4] package/sysdig: New package

Sysdig is open source, system-level exploration:
capture system state and activity from a running Linux
instance, then save, filter and analyze.

Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
Changes v3 -> v4:
  - Changed "depends on" to "select" and fixed selected packages
    dependencies.
  - moved "comment" section to the bottom

Changes v2 -> v3:
  - Changed "depends on" and "select" to simplify package

Changes v1 -> v2:
  - Changed "depends on" with "select" for dependencies (suggested by Baruch)
  - Added comment "sysdig needs a Linux kernel to be built" (suggested by Baruch)
  - Upgreded to recently released 0.1.99

 package/Config.in        |  1 +
 package/sysdig/Config.in | 22 ++++++++++++++++++++++
 package/sysdig/sysdig.mk | 22 ++++++++++++++++++++++
 3 files changed, 45 insertions(+)
 create mode 100644 package/sysdig/Config.in
 create mode 100644 package/sysdig/sysdig.mk

Dear Angelo Compagnucci,

On Tue, 17 Mar 2015 15:48:47 +0100, Angelo Compagnucci wrote:
> diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
> new file mode 100644
> index 0000000..52c3703
> --- /dev/null
> +++ b/package/sysdig/Config.in
> @@ -0,0 +1,22 @@
> +config BR2_PACKAGE_SYSDIG
> +	bool "sysdig"
> +	select BR2_PACKAGE_ZLIB
> +	select BR2_PACKAGE_LUAJIT

Unless I missed it, you did not reply to my question: is LuaJIT
mandatory, or can sysdig use the normal Lua interpreter as well?

> +	select BR2_PACKAGE_LIBJSON
> +	depends on BR2_LINUX_KERNEL
> +	depends on BR2_INSTALL_LIBSTDCPP #Libjson

Nitpick: # libjson

(i.e space after #, and lowercase package name)

> +	depends on BR2_i386 || (BR2_x86_64 && BR2_HOSTARCH='x86_64') \
> +		|| BR2_powerpc || BR2_arm || BR2_armeb \
> +		|| ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT) #Luajit

Please introduce a BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS hidden option in
luajit/Config.in, and use it in both luajit/Config.in and here. See
what Samuel did with the BR2_PACKAGE_CMAKE_ARCH_SUPPORTS option today.

> +comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
> +	depends on !BR2_LINUX_KERNEL
> +	depends on !BR2_INSTALL_LIBSTDCPP

	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS

> +SYSDIG_VERSION = 0.1.99
> +SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
> +SYSDIG_LICENSE = GPLv2
> +SYSDIG_LICENSE_FILES = COPYING
> +SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF
> +SYSDIG_DEPENDENCIES += zlib luajit libjson linux

Replace += by = here.

Thanks!

Thomas

Dear Thomas Petazzoni,

> Unless I missed it, you did not reply to my question: is LuaJIT
> mandatory, or can sysdig use the normal Lua interpreter as well?

Sorry, you are right. Unfortunately sysdig depend on Luajit, you can
find more info here [1].

>
>> +     select BR2_PACKAGE_LIBJSON
>> +     depends on BR2_LINUX_KERNEL
>> +     depends on BR2_INSTALL_LIBSTDCPP #Libjson
>
> Nitpick: # libjson
>
> (i.e space after #, and lowercase package name)

Ok!

>
>> +     depends on BR2_i386 || (BR2_x86_64 && BR2_HOSTARCH='x86_64') \
>> +             || BR2_powerpc || BR2_arm || BR2_armeb \
>> +             || ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT) #Luajit
>
> Please introduce a BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS hidden option in
> luajit/Config.in, and use it in both luajit/Config.in and here. See
> what Samuel did with the BR2_PACKAGE_CMAKE_ARCH_SUPPORTS option today.

Ok!

>
>> +comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
>> +     depends on !BR2_LINUX_KERNEL
>> +     depends on !BR2_INSTALL_LIBSTDCPP
>
>         depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>
>> +SYSDIG_VERSION = 0.1.99
>> +SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
>> +SYSDIG_LICENSE = GPLv2
>> +SYSDIG_LICENSE_FILES = COPYING
>> +SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF
>> +SYSDIG_DEPENDENCIES += zlib luajit libjson linux
>
> Replace += by = here.

Ok!

>
> Thanks!

Thank you too!

Sincerely, Angelo

>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

[1] http://www.sysdig.org/wiki/how-to-install-sysdig-from-the-source-code/

Hi Angelo,

> Sysdig is open source, system-level exploration:
> capture system state and activity from a running Linux
> instance, then save, filter and analyze.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> ---
> Changes v3 -> v4:
>    - Changed "depends on" to "select" and fixed selected packages
>      dependencies.
>    - moved "comment" section to the bottom
>
> Changes v2 -> v3:
>    - Changed "depends on" and "select" to simplify package
>
> Changes v1 -> v2:
>    - Changed "depends on" with "select" for dependencies (suggested by Baruch)
>    - Added comment "sysdig needs a Linux kernel to be built" (suggested by Baruch)
>    - Upgreded to recently released 0.1.99
>
>   package/Config.in        |  1 +
>   package/sysdig/Config.in | 22 ++++++++++++++++++++++
>   package/sysdig/sysdig.mk | 22 ++++++++++++++++++++++
>   3 files changed, 45 insertions(+)
>   create mode 100644 package/sysdig/Config.in
>   create mode 100644 package/sysdig/sysdig.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index e221deb..019d40b 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -94,6 +94,7 @@ endif
>   	source "package/strace/Config.in"
>   	source "package/stress/Config.in"
>   	source "package/sysprof/Config.in"
> +	source "package/sysdig/Config.in"
>   	source "package/tinymembench/Config.in"
>   	source "package/trace-cmd/Config.in"
>   	source "package/trinity/Config.in"
> diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
> new file mode 100644
> index 0000000..52c3703
> --- /dev/null
> +++ b/package/sysdig/Config.in
> @@ -0,0 +1,22 @@
> +config BR2_PACKAGE_SYSDIG
> +	bool "sysdig"
> +	select BR2_PACKAGE_ZLIB
> +	select BR2_PACKAGE_LUAJIT
> +	select BR2_PACKAGE_LIBJSON
> +	depends on BR2_LINUX_KERNEL
> +	depends on BR2_INSTALL_LIBSTDCPP #Libjson
> +	depends on BR2_i386 || (BR2_x86_64 && BR2_HOSTARCH='x86_64') \
> +		|| BR2_powerpc || BR2_arm || BR2_armeb \
> +		|| ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT) #Luajit
> +	help
> +	  Sysdig is open source, system-level exploration:
> +	  capture system state and activity from a running Linux instance,
> +	  then save, filter and analyze.
> +	  Think of it as strace + tcpdump + lsof + awesome sauce.
> +	  With a little Lua cherry on top.
> +
> +	  http://sysdig.org
> +
> +comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
> +	depends on !BR2_LINUX_KERNEL
> +	depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/sysdig/sysdig.mk b/package/sysdig/sysdig.mk
> new file mode 100644
> index 0000000..1bed0c0
> --- /dev/null
> +++ b/package/sysdig/sysdig.mk
> @@ -0,0 +1,22 @@
> +#############################################################

This and ...

> +#
> +# sysdig
> +#
> +#############################################################

... that separator should consist of 80 #'es.

Regards,
Jerzy

> +
> +SYSDIG_VERSION = 0.1.99
> +SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
> +SYSDIG_LICENSE = GPLv2
> +SYSDIG_LICENSE_FILES = COPYING
> +SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF
> +SYSDIG_DEPENDENCIES += zlib luajit libjson linux
> +SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
> +
> +define SYSDIG_INSTALL_DRIVER
> +	$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D)/driver modules
> +	$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D)/driver modules_install
> +endef
> +
> +SYSDIG_POST_INSTALL_TARGET_HOOKS += SYSDIG_INSTALL_DRIVER
> +
> +$(eval $(cmake-package))