Message ID | 1426736888-29437-4-git-send-email-steven@uplinklabs.net |
---|---|
State | Superseded |
Headers | show |
Hi Steven, On Wed, Mar 18, 2015 at 08:48:06PM -0700, Steven Noonan wrote: > Signed-off-by: Steven Noonan <steven@uplinklabs.net> This is a non trivial version bump. Please explain here that the package now uses the autotools infrastructure. > --- > package/numactl/numactl.mk | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/package/numactl/numactl.mk b/package/numactl/numactl.mk > index f36a1b3..042f2d8 100644 > --- a/package/numactl/numactl.mk > +++ b/package/numactl/numactl.mk > @@ -4,17 +4,11 @@ > # > ################################################################################ > > -NUMACTL_VERSION = 2.0.9 > +NUMACTL_VERSION = 2.0.10 > NUMACTL_SITE = ftp://oss.sgi.com/www/projects/libnuma/download > NUMACTL_LICENSE = LGPLv2.1 (libnuma), GPLv2 (programs) > NUMACTL_LICENSE_FILES = README > > -define NUMACTL_BUILD_CMDS > - $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) > -endef > +NUMACTL_AUTORECONF = YES Why? Please add inline comment clarifying that. baruch
On Wed, Mar 18, 2015 at 10:26 PM, Baruch Siach <baruch@tkos.co.il> wrote: > Hi Steven, > > On Wed, Mar 18, 2015 at 08:48:06PM -0700, Steven Noonan wrote: >> Signed-off-by: Steven Noonan <steven@uplinklabs.net> > > This is a non trivial version bump. Please explain here that the package now > uses the autotools infrastructure. > >> --- >> package/numactl/numactl.mk | 12 +++--------- >> 1 file changed, 3 insertions(+), 9 deletions(-) >> >> diff --git a/package/numactl/numactl.mk b/package/numactl/numactl.mk >> index f36a1b3..042f2d8 100644 >> --- a/package/numactl/numactl.mk >> +++ b/package/numactl/numactl.mk >> @@ -4,17 +4,11 @@ >> # >> ################################################################################ >> >> -NUMACTL_VERSION = 2.0.9 >> +NUMACTL_VERSION = 2.0.10 >> NUMACTL_SITE = ftp://oss.sgi.com/www/projects/libnuma/download >> NUMACTL_LICENSE = LGPLv2.1 (libnuma), GPLv2 (programs) >> NUMACTL_LICENSE_FILES = README >> >> -define NUMACTL_BUILD_CMDS >> - $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) >> -endef >> +NUMACTL_AUTORECONF = YES > > Why? Please add inline comment clarifying that. Fair enough. The reason is because the numactl tarball doesn't already contain a configure script, but does contain configure.ac, Makefile.am, etc. Will add a comment.
diff --git a/package/numactl/numactl.mk b/package/numactl/numactl.mk index f36a1b3..042f2d8 100644 --- a/package/numactl/numactl.mk +++ b/package/numactl/numactl.mk @@ -4,17 +4,11 @@ # ################################################################################ -NUMACTL_VERSION = 2.0.9 +NUMACTL_VERSION = 2.0.10 NUMACTL_SITE = ftp://oss.sgi.com/www/projects/libnuma/download NUMACTL_LICENSE = LGPLv2.1 (libnuma), GPLv2 (programs) NUMACTL_LICENSE_FILES = README -define NUMACTL_BUILD_CMDS - $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -endef +NUMACTL_AUTORECONF = YES -define NUMACTL_INSTALL_TARGET_CMDS - $(MAKE) prefix=$(TARGET_DIR) libdir=$(TARGET_DIR)/lib -C $(@D) install -endef - -$(eval $(generic-package)) +$(eval $(autotools-package))
Signed-off-by: Steven Noonan <steven@uplinklabs.net> --- package/numactl/numactl.mk | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)