| Message ID | 1425471185-19153-1-git-send-email-boris.brezillon@free-electrons.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
On Wed, Mar 4, 2015 at 9:13 AM, Boris Brezillon <boris.brezillon@free-electrons.com> wrote: > Freescale boards are currently all defined in arch/arm/Kconfig, which > makes them hard to detect. > Moreover the MX6 SoC variant (Q, D, DL, S, SL) selection is currently > done via the SYS_EXTRA_OPTIONS option which marked as deprecated. > > Move to a more standard way to select sub-architecture and board by > creating a Kconfig under arch/arm/cpu/armv7/mx6 and a new ARCH_MX6 > option. > > Existing MX6 board definitions should be moved in this new Kconfig in > choice menu, and new boards should be directly declared in this menu. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> As this adds the board definitions, are you going to also send a patch to the existing boards?
On Wed, 4 Mar 2015 09:43:59 -0300 Otavio Salvador <otavio@ossystems.com.br> wrote: > On Wed, Mar 4, 2015 at 9:13 AM, Boris Brezillon > <boris.brezillon@free-electrons.com> wrote: > > Freescale boards are currently all defined in arch/arm/Kconfig, which > > makes them hard to detect. > > Moreover the MX6 SoC variant (Q, D, DL, S, SL) selection is currently > > done via the SYS_EXTRA_OPTIONS option which marked as deprecated. > > > > Move to a more standard way to select sub-architecture and board by > > creating a Kconfig under arch/arm/cpu/armv7/mx6 and a new ARCH_MX6 > > option. > > > > Existing MX6 board definitions should be moved in this new Kconfig in > > choice menu, and new boards should be directly declared in this menu. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > As this adds the board definitions, are you going to also send a patch > to the existing boards? > If that's accepted, then yes I could help moving boards from the old approach to the new one, though I was expecting this to be done by board maintainers. Note that I'm not breaking anything (the old boards definition are still working).
Hi Boris, On 04/03/2015 13:50, Boris Brezillon wrote: >> > > If that's accepted, then yes I could help moving boards from the old > approach to the new one, though I was expecting this to be done by > board maintainers. > > Note that I'm not breaking anything (the old boards definition are > still working). Yes, this was also my concern, but I saw that no board is broken. Then I agree that the other boards can be moved later. Regards, Stefano
Hi Stefano, On Wed, 04 Mar 2015 16:43:44 +0100 Stefano Babic <sbabic@denx.de> wrote: > Hi Boris, > > On 04/03/2015 13:50, Boris Brezillon wrote: > >> > > > > If that's accepted, then yes I could help moving boards from the old > > approach to the new one, though I was expecting this to be done by > > board maintainers. > > > > Note that I'm not breaking anything (the old boards definition are > > still working). > > Yes, this was also my concern, but I saw that no board is broken. Then I > agree that the other boards can be moved later. Is there anything missing in this series or anything you'd like me to change (a.k.a. ping :-)). Best Regards, Boris
Hi Boris, On 18/03/2015 10:49, Boris Brezillon wrote: > Hi Stefano, > > On Wed, 04 Mar 2015 16:43:44 +0100 > Stefano Babic <sbabic@denx.de> wrote: > >> Hi Boris, >> >> On 04/03/2015 13:50, Boris Brezillon wrote: >>>> >>> >>> If that's accepted, then yes I could help moving boards from the old >>> approach to the new one, though I was expecting this to be done by >>> board maintainers. >>> >>> Note that I'm not breaking anything (the old boards definition are >>> still working). >> >> Yes, this was also my concern, but I saw that no board is broken. Then I >> agree that the other boards can be moved later. > > Is there anything missing in this series or anything you'd like me to > change (a.k.a. ping :-)). Ouch...thanks for ping, I was convinced that there some open issues, and for that reasonI have not applied your patches. I had to reread the thread :-). I set them to be applied. Best regards, Stefano
On 04/03/2015 13:13, Boris Brezillon wrote: > Freescale boards are currently all defined in arch/arm/Kconfig, which > makes them hard to detect. > Moreover the MX6 SoC variant (Q, D, DL, S, SL) selection is currently > done via the SYS_EXTRA_OPTIONS option which marked as deprecated. > > Move to a more standard way to select sub-architecture and board by > creating a Kconfig under arch/arm/cpu/armv7/mx6 and a new ARCH_MX6 > option. > > Existing MX6 board definitions should be moved in this new Kconfig in > choice menu, and new boards should be directly declared in this menu. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 1f1ccad..7984bef 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -563,6 +563,10 @@ config ARCH_KEYSTONE select CPU_V7 select SUPPORT_SPL +config ARCH_MX6 + bool "Freescale MX6" + select CPU_V7 + config TARGET_M53EVK bool "Support m53evk" select CPU_V7 @@ -847,6 +851,8 @@ source "arch/arm/cpu/armv7/keystone/Kconfig" source "arch/arm/cpu/arm926ejs/kirkwood/Kconfig" +source "arch/arm/cpu/armv7/mx6/Kconfig" + source "arch/arm/cpu/arm926ejs/nomadik/Kconfig" source "arch/arm/cpu/armv7/omap3/Kconfig" diff --git a/arch/arm/cpu/armv7/mx6/Kconfig b/arch/arm/cpu/armv7/mx6/Kconfig new file mode 100644 index 0000000..a32fd87 --- /dev/null +++ b/arch/arm/cpu/armv7/mx6/Kconfig @@ -0,0 +1,31 @@ +if ARCH_MX6 + +config MX6 + bool + default y + +config MX6D + bool + +config MX6DL + bool + +config MX6Q + bool + +config MX6QDL + bool + +config MX6S + bool + +config MX6SL + bool + +config MX6SX + bool + +config SYS_SOC + default "mx6" + +endif
Freescale boards are currently all defined in arch/arm/Kconfig, which makes them hard to detect. Moreover the MX6 SoC variant (Q, D, DL, S, SL) selection is currently done via the SYS_EXTRA_OPTIONS option which marked as deprecated. Move to a more standard way to select sub-architecture and board by creating a Kconfig under arch/arm/cpu/armv7/mx6 and a new ARCH_MX6 option. Existing MX6 board definitions should be moved in this new Kconfig in choice menu, and new boards should be directly declared in this menu. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> --- arch/arm/Kconfig | 6 ++++++ arch/arm/cpu/armv7/mx6/Kconfig | 31 +++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 arch/arm/cpu/armv7/mx6/Kconfig