diff mbox

[1/2] net: macb: Include multi queue support for xilinx ZynqMP ethernet version

Message ID c4d6dd80406da35180f2f4fc163b1c7fc526d92a.1425560649.git.michal.simek@xilinx.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Michal Simek March 5, 2015, 1:04 p.m. UTC
From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>

Include multi queue support for the ethernet IP version in xilinx ZynqMP
SoC.

Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/net/ethernet/cadence/macb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michal Simek March 5, 2015, 2 p.m. UTC | #1
Hi Nicolas,

On 03/05/2015 02:04 PM, Michal Simek wrote:
> From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>
> 
> Include multi queue support for the ethernet IP version in xilinx ZynqMP
> SoC.
> 
> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/net/ethernet/cadence/macb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index ad76b8e35a00..24b1eb466e52 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -2192,7 +2192,7 @@ static void macb_probe_queues(void __iomem *mem,
>  
>  	/* is it macb or gem ? */
>  	mid = __raw_readl(mem + MACB_MID);
> -	if (MACB_BFEXT(IDNUM, mid) != 0x2)
> +	if (MACB_BFEXT(IDNUM, mid) < 0x2)
>  		return;
>  
>  	/* bit 0 is never set but queue 0 always exists */
> 

Can you please check this?
(There will be definitely v2 because I forget to base it on net-next).

Thanks,
Michal
Nicolas Ferre March 6, 2015, 4:48 p.m. UTC | #2
Le 05/03/2015 15:00, Michal Simek a écrit :
> Hi Nicolas,
> 
> On 03/05/2015 02:04 PM, Michal Simek wrote:
>> From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>
>>
>> Include multi queue support for the ethernet IP version in xilinx ZynqMP
>> SoC.
>>
>> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  drivers/net/ethernet/cadence/macb.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
>> index ad76b8e35a00..24b1eb466e52 100644
>> --- a/drivers/net/ethernet/cadence/macb.c
>> +++ b/drivers/net/ethernet/cadence/macb.c
>> @@ -2192,7 +2192,7 @@ static void macb_probe_queues(void __iomem *mem,
>>  
>>  	/* is it macb or gem ? */
>>  	mid = __raw_readl(mem + MACB_MID);
>> -	if (MACB_BFEXT(IDNUM, mid) != 0x2)
>> +	if (MACB_BFEXT(IDNUM, mid) < 0x2)
>>  		return;
>>  
>>  	/* bit 0 is never set but queue 0 always exists */
>>
> 
> Can you please check this?
> (There will be definitely v2 because I forget to base it on net-next).

Michal,

It seems correct to me: you can add my:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Bye,
diff mbox

Patch

diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index ad76b8e35a00..24b1eb466e52 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -2192,7 +2192,7 @@  static void macb_probe_queues(void __iomem *mem,
 
 	/* is it macb or gem ? */
 	mid = __raw_readl(mem + MACB_MID);
-	if (MACB_BFEXT(IDNUM, mid) != 0x2)
+	if (MACB_BFEXT(IDNUM, mid) < 0x2)
 		return;
 
 	/* bit 0 is never set but queue 0 always exists */