Message ID | 1425484811-26238-3-git-send-email-gwenj@trabucayre.com |
---|---|
State | Superseded |
Headers | show |
Dear Gwenhael Goavec-Merou, On Wed, 4 Mar 2015 17:00:10 +0100, Gwenhael Goavec-Merou wrote: > diff --git a/package/python-cheetah/python-cheetah.mk b/package/python-cheetah/python-cheetah.mk > index 08076b5..faf2436 100644 > --- a/package/python-cheetah/python-cheetah.mk > +++ b/package/python-cheetah/python-cheetah.mk > @@ -9,5 +9,7 @@ PYTHON_CHEETAH_SOURCE = Cheetah-$(PYTHON_CHEETAH_VERSION).tar.gz > PYTHON_CHEETAH_SITE = http://pypi.python.org/packages/source/C/Cheetah > PYTHON_CHEETAH_LICENSE = MIT > PYTHON_CHEETAH_SETUP_TYPE = setuptools > +PYTHON_CHEETAH_DEPENDENCIES += host-python-markdown Are you sure you need to add host-python-markdown as a dependency to the target python-cheetah package ? I.e, I'd like to understand if what you need is: PYTHON_CHEETAH_DEPENDENCIES = host-python-markdown (i.e adds host-python-markdown to the dependencies of both python-cheetah and host-python-cheetah) *OR* PYTHON_CHEETAH_DEPENDENCIES = python-markdown (i.e adds python-markdown to the dependencies of python-cheetah, and host-python-markdown to the dependencies of host-python-cheetah) *OR* HOST_PYTHON_CHEETAH_DEPENDENCIES = host-python-markdown (i.e adds host-python-markdown to the dependencies of host-python-cheetah) Also, use '=' and not '+=' in such situations. Thanks! Thomas
Dear Thomas Petazzoni On Wed, 4 Mar 2015 22:49:40 +0100 Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Gwenhael Goavec-Merou, > > On Wed, 4 Mar 2015 17:00:10 +0100, Gwenhael Goavec-Merou wrote: > > > diff --git a/package/python-cheetah/python-cheetah.mk b/package/python-cheetah/python-cheetah.mk > > index 08076b5..faf2436 100644 > > --- a/package/python-cheetah/python-cheetah.mk > > +++ b/package/python-cheetah/python-cheetah.mk > > @@ -9,5 +9,7 @@ PYTHON_CHEETAH_SOURCE = Cheetah-$(PYTHON_CHEETAH_VERSION).tar.gz > > PYTHON_CHEETAH_SITE = http://pypi.python.org/packages/source/C/Cheetah > > PYTHON_CHEETAH_LICENSE = MIT > > PYTHON_CHEETAH_SETUP_TYPE = setuptools > > +PYTHON_CHEETAH_DEPENDENCIES += host-python-markdown > > Are you sure you need to add host-python-markdown as a dependency to > the target python-cheetah package ? I.e, I'd like to understand if what > you need is: > > PYTHON_CHEETAH_DEPENDENCIES = host-python-markdown > > (i.e adds host-python-markdown to the dependencies of both > python-cheetah and host-python-cheetah) > > *OR* > > PYTHON_CHEETAH_DEPENDENCIES = python-markdown > > (i.e adds python-markdown to the dependencies of python-cheetah, and > host-python-markdown to the dependencies of host-python-cheetah) > > *OR* > > HOST_PYTHON_CHEETAH_DEPENDENCIES = host-python-markdown > > (i.e adds host-python-markdown to the dependencies of > host-python-cheetah) > I'm wrong, it's true, host-python-markdown is only needed for host-python-cheetah. I think the best solution is the second option, ie. PYTHON_CHEETAH_DEPENDENCIES = python-markdown to be sure to have the correct dependency in all case (although python-cheetah as not really needed to python-markdown to be compiles). > > Also, use '=' and not '+=' in such situations. > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com Regards Gwen
Hello, On Thu, 5 Mar 2015 09:40:49 +0100, gwenhael.goavec wrote: > I'm wrong, it's true, host-python-markdown is only needed for > host-python-cheetah. I think the best solution is the second option, ie. > PYTHON_CHEETAH_DEPENDENCIES = python-markdown to be sure to have the correct > dependency in all case (although python-cheetah as not really needed to > python-markdown to be compiles). If only host-python-markdown is needed to build host-python-cheetah, then the correct solution is: HOST_PYTHON_CHEETAH_DEPENDENCIES = host-python-markdown Best regards, Thomas
diff --git a/package/python-cheetah/python-cheetah.mk b/package/python-cheetah/python-cheetah.mk index 08076b5..faf2436 100644 --- a/package/python-cheetah/python-cheetah.mk +++ b/package/python-cheetah/python-cheetah.mk @@ -9,5 +9,7 @@ PYTHON_CHEETAH_SOURCE = Cheetah-$(PYTHON_CHEETAH_VERSION).tar.gz PYTHON_CHEETAH_SITE = http://pypi.python.org/packages/source/C/Cheetah PYTHON_CHEETAH_LICENSE = MIT PYTHON_CHEETAH_SETUP_TYPE = setuptools +PYTHON_CHEETAH_DEPENDENCIES += host-python-markdown $(eval $(python-package)) +$(eval $(host-python-package))