diff mbox

kmod: needs largefile

Message ID 1425447280-21873-1-git-send-email-fabio.porcedda@gmail.com
State Superseded
Headers show

Commit Message

Fabio Porcedda March 4, 2015, 5:34 a.m. UTC 
Since version 20 it requires largefile support.

http://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/?id=481ad14550087c77c9df6d117c7a975a38a4ad33
 - Disable --disable-largefile. We already had possible bugs in the
   index implementation if this were passed. It's now fixed, but it's
   never tested. Disable it.

Fix build failure:
configure: error: --disable-largefile is not supported by kmod
package/pkg-generic.mk:172: recipe for target 'output/build/kmod-20/.stamp_configured' failed

Fixes:
http://autobuild.buildroot.net/results/f662d9230e4bc2da7dc56a2ffd493cc37254d377//
http://autobuild.buildroot.net/results/233ec8ee346e15d41658cffc6bbb4a6c9dd46746//
---
 package/kmod/Config.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Baruch Siach March 4, 2015, 5:44 a.m. UTC | #1 
Hi Fabio,

On Wed, Mar 04, 2015 at 06:34:40AM +0100, Fabio Porcedda wrote:
> Since version 20 it requires largefile support.
> 
> http://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/?id=481ad14550087c77c9df6d117c7a975a38a4ad33
>  - Disable --disable-largefile. We already had possible bugs in the
>    index implementation if this were passed. It's now fixed, but it's
>    never tested. Disable it.
> 
> Fix build failure:
> configure: error: --disable-largefile is not supported by kmod
> package/pkg-generic.mk:172: recipe for target 'output/build/kmod-20/.stamp_configured' failed
> 
> Fixes:
> http://autobuild.buildroot.net/results/f662d9230e4bc2da7dc56a2ffd493cc37254d377//
> http://autobuild.buildroot.net/results/233ec8ee346e15d41658cffc6bbb4a6c9dd46746//

Your SoB is missing.

baruch
Fabio Porcedda March 4, 2015, 7:08 a.m. UTC | #2 
On Wed, Mar 4, 2015 at 6:44 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Fabio,
>
> On Wed, Mar 04, 2015 at 06:34:40AM +0100, Fabio Porcedda wrote:
>> Since version 20 it requires largefile support.
>>
>> http://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/?id=481ad14550087c77c9df6d117c7a975a38a4ad33
>>  - Disable --disable-largefile. We already had possible bugs in the
>>    index implementation if this were passed. It's now fixed, but it's
>>    never tested. Disable it.
>>
>> Fix build failure:
>> configure: error: --disable-largefile is not supported by kmod
>> package/pkg-generic.mk:172: recipe for target 'output/build/kmod-20/.stamp_configured' failed
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/f662d9230e4bc2da7dc56a2ffd493cc37254d377//
>> http://autobuild.buildroot.net/results/233ec8ee346e15d41658cffc6bbb4a6c9dd46746//
>
> Your SoB is missing.

Thanks for reviewing.

I've sent an update patch adding the SoB line:
http://patchwork.ozlabs.org/patch/446121/

BR
diff mbox

Patch

diff --git a/package/kmod/Config.in b/package/kmod/Config.in
index 8703e82..745c9e2 100644
--- a/package/kmod/Config.in
+++ b/package/kmod/Config.in
@@ -1,6 +1,6 @@ 
 config BR2_PACKAGE_KMOD
 	bool "kmod"
-	depends on !BR2_STATIC_LIBS
+	depends on !BR2_STATIC_LIBS && BR2_LARGEFILE
 	help
 	  handle kernel modules
 
@@ -16,3 +16,6 @@  config BR2_PACKAGE_KMOD_TOOLS
 	  modinfo, modprobe, rmmod).
 
 endif
+
+comment "kmod needs a toolchain w/ largefile"
+	depends on !BR2_LARGEFILE