diff mbox

fix PR65048: check that jump-thread paths are still valid

Message ID 20150225191843.GA13649@f1.c.bardezibar.internal
State New
Headers show

Commit Message

Sebastian Pop Feb. 25, 2015, 7:18 p.m. UTC 
Jeff Law wrote:
> On 02/18/15 15:27, Sebastian Pop wrote:
> >>The dumps for the FSM threads are a bit sparse -- they don't show
> >>the entire path.  That makes it much harder to see what's going on.
> >
> >Would a patch improving the FSM dumps ok to commit separately to trunk?
> Most definitely.  I realize we're in stage4, but I'd approve such a change.

Attached:

        * tree-ssa-threadupdate.c (dump_jump_thread_path): Print all edges
        of an EDGE_FSM_THREAD.

I'm regstrapping on x86_64-linux.  Ok for trunk if it passes?

Thanks,
Sebastian

Comments

Jeff Law Feb. 25, 2015, 9:02 p.m. UTC | #1 
On 02/25/15 12:18, Sebastian Pop wrote:
> Jeff Law wrote:
>> On 02/18/15 15:27, Sebastian Pop wrote:
>>>> The dumps for the FSM threads are a bit sparse -- they don't show
>>>> the entire path.  That makes it much harder to see what's going on.
>>>
>>> Would a patch improving the FSM dumps ok to commit separately to trunk?
>> Most definitely.  I realize we're in stage4, but I'd approve such a change.
>
> Attached:
>
>          * tree-ssa-threadupdate.c (dump_jump_thread_path): Print all edges
>          of an EDGE_FSM_THREAD.
>
> I'm regstrapping on x86_64-linux.  Ok for trunk if it passes?
Yes.

jeff
Sebastian Pop Feb. 26, 2015, 5:26 p.m. UTC | #2 
Jeff Law wrote:
> On 02/25/15 12:18, Sebastian Pop wrote:
> >Jeff Law wrote:
> >>On 02/18/15 15:27, Sebastian Pop wrote:
> >>>>The dumps for the FSM threads are a bit sparse -- they don't show
> >>>>the entire path.  That makes it much harder to see what's going on.
> >>>
> >>>Would a patch improving the FSM dumps ok to commit separately to trunk?
> >>Most definitely.  I realize we're in stage4, but I'd approve such a change.
> >
> >Attached:
> >
> >         * tree-ssa-threadupdate.c (dump_jump_thread_path): Print all edges
> >         of an EDGE_FSM_THREAD.
> >
> >I'm regstrapping on x86_64-linux.  Ok for trunk if it passes?
> Yes.

Committed r221021.

Sebastian
diff mbox

Patch

From df583e5d511db2ed87c14cd5290f382c139636d9 Mon Sep 17 00:00:00 2001
From: Sebastian Pop <sebpop@gmail.com>
Date: Wed, 25 Feb 2015 20:12:33 +0100
Subject: [PATCH] improve FSM jump thread dump

---
 gcc/tree-ssa-threadupdate.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gcc/tree-ssa-threadupdate.c b/gcc/tree-ssa-threadupdate.c
index 7a41ab2..7a159bb 100644
--- a/gcc/tree-ssa-threadupdate.c
+++ b/gcc/tree-ssa-threadupdate.c
@@ -197,6 +197,9 @@  dump_jump_thread_path (FILE *dump_file, vec<jump_thread_edge *> path,
       if (path[i]->type == EDGE_NO_COPY_SRC_BLOCK)
        fprintf (dump_file, " (%d, %d) nocopy;",
 		 path[i]->e->src->index, path[i]->e->dest->index);
+      if (path[0]->type == EDGE_FSM_THREAD)
+	fprintf (dump_file, " (%d, %d) ",
+		 path[i]->e->src->index, path[i]->e->dest->index);
     }
   fputc ('\n', dump_file);
 }
-- 
1.7.2.5