| Message ID | 1423849041-7978-1-git-send-email-angelo.compagnucci@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Feb 13, 2015 at 6:37 PM, Angelo Compagnucci <angelo.compagnucci@gmail.com> wrote: > This patch changes BR2_PACKAGE_PYTHON_PYEXPAT description and > help text to underline that all the xml libraries will be > included in python. > It also reorders alphabetically the affected option. > > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> > --- > package/python/Config.in | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/package/python/Config.in b/package/python/Config.in > index 87defad..5a22833 100644 > --- a/package/python/Config.in > +++ b/package/python/Config.in > @@ -65,12 +65,6 @@ config BR2_PACKAGE_PYTHON_OSSAUDIODEV > help > ossaudiodev module for Python. > > -config BR2_PACKAGE_PYTHON_PYEXPAT > - select BR2_PACKAGE_EXPAT > - bool "pyexpat" > - help > - pyexpat module for Python. > - > config BR2_PACKAGE_PYTHON_READLINE > select BR2_PACKAGE_READLINE > bool "readline" > @@ -114,6 +108,12 @@ config BR2_PACKAGE_PYTHON_SQLITE > help > SQLite database support > > +config BR2_PACKAGE_PYTHON_PYEXPAT > + select BR2_PACKAGE_EXPAT > + bool "xml module" > + help > + pyexpat and xml libraries for Python > + > config BR2_PACKAGE_PYTHON_ZLIB > bool "zlib module" > select BR2_PACKAGE_ZLIB > -- Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
On Fri, Feb 13, 2015 at 8:58 PM, Yegor Yefremov <yegorslists@googlemail.com> wrote: > On Fri, Feb 13, 2015 at 6:37 PM, Angelo Compagnucci > <angelo.compagnucci@gmail.com> wrote: >> This patch changes BR2_PACKAGE_PYTHON_PYEXPAT description and >> help text to underline that all the xml libraries will be >> included in python. >> It also reorders alphabetically the affected option. >> >> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> >> --- >> package/python/Config.in | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/package/python/Config.in b/package/python/Config.in >> index 87defad..5a22833 100644 >> --- a/package/python/Config.in >> +++ b/package/python/Config.in >> @@ -65,12 +65,6 @@ config BR2_PACKAGE_PYTHON_OSSAUDIODEV >> help >> ossaudiodev module for Python. >> >> -config BR2_PACKAGE_PYTHON_PYEXPAT >> - select BR2_PACKAGE_EXPAT >> - bool "pyexpat" >> - help >> - pyexpat module for Python. >> - >> config BR2_PACKAGE_PYTHON_READLINE >> select BR2_PACKAGE_READLINE >> bool "readline" >> @@ -114,6 +108,12 @@ config BR2_PACKAGE_PYTHON_SQLITE >> help >> SQLite database support >> >> +config BR2_PACKAGE_PYTHON_PYEXPAT >> + select BR2_PACKAGE_EXPAT >> + bool "xml module" >> + help >> + pyexpat and xml libraries for Python >> + >> config BR2_PACKAGE_PYTHON_ZLIB >> bool "zlib module" >> select BR2_PACKAGE_ZLIB >> -- > > Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com> Hm. We forgot about Python3. Could you resend your patch , that would also take care of package/python3/Config.in. Or perhaps extra patch for Python3. Thanks. Yegor
Dear Angelo Compagnucci, On Fri, 13 Feb 2015 18:37:21 +0100, Angelo Compagnucci wrote: > This patch changes BR2_PACKAGE_PYTHON_PYEXPAT description and > help text to underline that all the xml libraries will be > included in python. > It also reorders alphabetically the affected option. > > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> Applied to next, thanks. Thomas
diff --git a/package/python/Config.in b/package/python/Config.in index 87defad..5a22833 100644 --- a/package/python/Config.in +++ b/package/python/Config.in @@ -65,12 +65,6 @@ config BR2_PACKAGE_PYTHON_OSSAUDIODEV help ossaudiodev module for Python. -config BR2_PACKAGE_PYTHON_PYEXPAT - select BR2_PACKAGE_EXPAT - bool "pyexpat" - help - pyexpat module for Python. - config BR2_PACKAGE_PYTHON_READLINE select BR2_PACKAGE_READLINE bool "readline" @@ -114,6 +108,12 @@ config BR2_PACKAGE_PYTHON_SQLITE help SQLite database support +config BR2_PACKAGE_PYTHON_PYEXPAT + select BR2_PACKAGE_EXPAT + bool "xml module" + help + pyexpat and xml libraries for Python + config BR2_PACKAGE_PYTHON_ZLIB bool "zlib module" select BR2_PACKAGE_ZLIB
This patch changes BR2_PACKAGE_PYTHON_PYEXPAT description and help text to underline that all the xml libraries will be included in python. It also reorders alphabetically the affected option. Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> --- package/python/Config.in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)