diff mbox

[v2] wf111: new package

Message ID 1422974005-21617-1-git-send-email-antoine.tenart@free-electrons.com
State Accepted
Headers show

Commit Message

Antoine Tenart Feb. 3, 2015, 2:33 p.m. UTC
Adds support for the BlueGiga WF111 WiFi driver and the binary utilities
distributed alongside the driver. An account is required to download the
sources from the BlueGiga website, which can be created freely. The
driver is available for armv5, arm7a and i386.

Since it is not possible to automatically retrieve the sources, because
of the required user account needed on the BlueGiga website, an option
is added to let the Buildroot user specify the directory where the
driver tarball was downloaded.

Finally, two options must be selected in the Linux kernel configuration:
CONFIG_WIRELESS_EXT and CONFIG_WEXT_PRIV. These are blind options (i.e.
not selectable directly) so they cannot be enabled by a change in
linux/linux.mk. The user as two choices to enable these options:
- By making them non blind, with a "WF111 support" configuration entry
  for example.
- By enabling another WiFi driver that select them.

The work behind this commit was funded by ECA Group
<http://www.ecagroup.com>. ECA Group is the copyright owner of the
contributed code.

Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
---

Changes since v1:
	- fixed various typos
	- added explanations about needed (blind) kernel options
	- added a comment in the menu when wf111 requirements are not met
	- used qstrip for string options
	- updated to use $(LINUX_MAKE_FLAGS)
	- used cp instead of rsync
	- added a check to be sure the configuration is correctly filled

 package/Config.in       |  1 +
 package/wf111/Config.in | 36 ++++++++++++++++++++++++++++++++++++
 package/wf111/wf111.mk  | 34 ++++++++++++++++++++++++++++++++++
 3 files changed, 71 insertions(+)
 create mode 100644 package/wf111/Config.in
 create mode 100644 package/wf111/wf111.mk

Comments

Thomas Petazzoni Feb. 20, 2015, 9:07 a.m. UTC | #1
Dear Antoine Tenart,

On Tue,  3 Feb 2015 15:33:25 +0100, Antoine Tenart wrote:
> Adds support for the BlueGiga WF111 WiFi driver and the binary utilities
> distributed alongside the driver. An account is required to download the
> sources from the BlueGiga website, which can be created freely. The
> driver is available for armv5, arm7a and i386.
> 
> Since it is not possible to automatically retrieve the sources, because
> of the required user account needed on the BlueGiga website, an option
> is added to let the Buildroot user specify the directory where the
> driver tarball was downloaded.
> 
> Finally, two options must be selected in the Linux kernel configuration:
> CONFIG_WIRELESS_EXT and CONFIG_WEXT_PRIV. These are blind options (i.e.
> not selectable directly) so they cannot be enabled by a change in
> linux/linux.mk. The user as two choices to enable these options:
> - By making them non blind, with a "WF111 support" configuration entry
>   for example.
> - By enabling another WiFi driver that select them.
> 
> The work behind this commit was funded by ECA Group
> <http://www.ecagroup.com>. ECA Group is the copyright owner of the
> contributed code.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>

Thanks, applied to next. It would be good however to send a followup
patch adding <pkg>_LICENSE and <pkg>_LICENSE_FILES.

Best regards,

Thomas Petazzoni
Antoine Tenart Feb. 20, 2015, 4:25 p.m. UTC | #2
Thomas,

On Fri, Feb 20, 2015 at 10:07:05AM +0100, Thomas Petazzoni wrote:
> On Tue,  3 Feb 2015 15:33:25 +0100, Antoine Tenart wrote:
> > Adds support for the BlueGiga WF111 WiFi driver and the binary utilities
> > distributed alongside the driver. An account is required to download the
> > sources from the BlueGiga website, which can be created freely. The
> > driver is available for armv5, arm7a and i386.
> > 
> > Since it is not possible to automatically retrieve the sources, because
> > of the required user account needed on the BlueGiga website, an option
> > is added to let the Buildroot user specify the directory where the
> > driver tarball was downloaded.
> > 
> > Finally, two options must be selected in the Linux kernel configuration:
> > CONFIG_WIRELESS_EXT and CONFIG_WEXT_PRIV. These are blind options (i.e.
> > not selectable directly) so they cannot be enabled by a change in
> > linux/linux.mk. The user as two choices to enable these options:
> > - By making them non blind, with a "WF111 support" configuration entry
> >   for example.
> > - By enabling another WiFi driver that select them.
> > 
> > The work behind this commit was funded by ECA Group
> > <http://www.ecagroup.com>. ECA Group is the copyright owner of the
> > contributed code.
> > 
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> 
> Thanks, applied to next. It would be good however to send a followup
> patch adding <pkg>_LICENSE and <pkg>_LICENSE_FILES.

I'd like to be able to provide a license, but all I can find is a
Copyright at the beginning of the source files, with the following
statement:

 * Refer to LICENSE.txt included with this source code for details on
 * the license terms.

And... the LICENSE.txt file can't be found :)

Antoine
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index d19b37f703db..e631fcb78f81 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -390,6 +390,7 @@  endif
 	source "package/usbmount/Config.in"
 	source "package/usbutils/Config.in"
 	source "package/w_scan/Config.in"
+	source "package/wf111/Config.in"
 	source "package/wipe/Config.in"
 	source "package/xorriso/Config.in"
 endmenu
diff --git a/package/wf111/Config.in b/package/wf111/Config.in
new file mode 100644
index 000000000000..d2ba440a90a0
--- /dev/null
+++ b/package/wf111/Config.in
@@ -0,0 +1,36 @@ 
+config BR2_PACKAGE_WF111
+	bool "wf111"
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_ARM_CPU_ARMV5 || BR2_ARM_CPU_ARMV7A || BR2_i386
+	# Binary tools are distributed alongside the driver, and are
+	# dynamically linked against the glibc.
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+	help
+	  BlueGiga WF111 WiFi driver and utilities.
+
+	  Warning: CONFIG_WIRELESS_EXT and CONFIG_WEXT_PRIV must be
+	  selected in the Linux kernel configuration. These are blind
+	  options (i.e. not selectable directly) so they cannot be
+	  enabled by a change in linux/linux.mk. There are two choices
+	  to enable these options:
+	  - By making them non blind, with a "WF111 support" configuration
+	    entry that selects them, for example.
+	  - By enabling another random WiFi driver that select them.
+
+	  http://www.bluegiga.com/en-US/products/wifi-modules/wf111-wifi-module/
+
+if BR2_PACKAGE_WF111
+
+config BR2_PACKAGE_WF111_TARBALL_PATH
+	string "Local tarball location"
+	help
+	  The WF111 tarball can be retrieved on the BlueGiga website
+	  after registration. This option specifies the path where the
+	  tarball is locally saved.
+
+endif
+
+comment "wf111 needs an (e)glibc toolchain"
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_ARM_CPU_ARMV5 || BR2_ARM_CPU_ARMV7A || BR2_i386
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
diff --git a/package/wf111/wf111.mk b/package/wf111/wf111.mk
new file mode 100644
index 000000000000..479d665760b1
--- /dev/null
+++ b/package/wf111/wf111.mk
@@ -0,0 +1,34 @@ 
+################################################################################
+#
+# wf111
+#
+################################################################################
+
+WF111_VERSION = 5.2.2
+WF111_SITE_METHOD = file
+WF111_SITE = $(call qstrip,$(BR2_PACKAGE_WF111_TARBALL_PATH))
+WF111_DEPENDENCIES = linux
+
+ifeq ($(BR2_PACKAGE_WF111)$(call qstrip,$(BR2_PACKAGE_WF111_TARBALL_PATH)),y)
+$(error No tarball location specified, check BR2_PACKAGE_WF111_TARBALL_PATH)
+endif
+
+ifeq ($(BR2_ARM_CPU_ARMV7A),y)
+WF111_SOURCE = wf111-linux-driver_5.2.2-r1_armv7-a.tar.gz
+else ifeq ($(BR2_ARM_CPU_ARMV5),y)
+WF111_SOURCE = wf111-linux-driver_5.2.2-r1_armv5t.tar.gz
+else ifeq ($(BR2_i386),y)
+WF111_SOURCE = wf111-linux-driver_5.2.2-r1_x86.tar.gz
+endif
+
+define WF111_BUILD_CMDS
+	$(MAKE) -C $(@D) PWD=$(@D) \
+		$(LINUX_MAKE_FLAGS) KDIR=$(LINUX_DIR) \
+		install_static
+endef
+
+define WF111_INSTALL_TARGET_CMDS
+	cp -dpfr $(@D)/output/* $(TARGET_DIR)
+endef
+
+$(eval $(generic-package))