Message ID | 1424118307-8154-1-git-send-email-andreas.devel@googlemail.com |
---|---|
State | Accepted |
Delegated to: | Tom Rini |
Headers | show |
On Mon, Feb 16, 2015 at 09:25:06PM +0100, Andreas Bießmann wrote: > Hi Tom, > > finally generic board support for avr32! > > The following changes since commit bd2a4888b123713adec271d6c8040ca9f609aa2f: > > sunxi: configs/sunxi-common.h: Enable CONFIG_CMD_PART (2015-02-11 19:43:45 -0500) > > are available in the git repository at: > > git://git.denx.de/u-boot-avr32.git master > > for you to fetch changes up to 4d3dada78ec402dc51e4198dda316301e0d99f35: > > atstk1002: enable generic board (2015-02-16 21:21:26 +0100) > NAK, sorry. This breaks MIPS: + malta +(malta) common/cmd_bdinfo.c: In function 'do_bdinfo': +(malta) common/cmd_bdinfo.c:328:34: error: 'bd_t' has no member named 'bi_dram' +(malta) common/cmd_bdinfo.c:329:32: error: 'bd_t' has no member named 'bi_dram' +(malta) make[2]: *** [common/cmd_bdinfo.o] Error 1 +(malta) make[1]: *** [common] Error 2 +(malta) make: *** [sub-make] Error 2 And it bisected down to: 09bf969d927f73b083101fabb77e5130bec3eec1 is the first bad commit commit 09bf969d927f73b083101fabb77e5130bec3eec1 Author: Andreas Bießmann <andreas.devel@googlemail.com> Date: Fri Feb 6 23:06:48 2015 +0100 avr32: add generic board support Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
Hi Tom, On 02/17/2015 04:12 PM, Tom Rini wrote: > On Mon, Feb 16, 2015 at 09:25:06PM +0100, Andreas Bießmann wrote: > >> Hi Tom, >> >> finally generic board support for avr32! >> >> The following changes since commit bd2a4888b123713adec271d6c8040ca9f609aa2f: >> >> sunxi: configs/sunxi-common.h: Enable CONFIG_CMD_PART (2015-02-11 19:43:45 -0500) >> >> are available in the git repository at: >> >> git://git.denx.de/u-boot-avr32.git master >> >> for you to fetch changes up to 4d3dada78ec402dc51e4198dda316301e0d99f35: >> >> atstk1002: enable generic board (2015-02-16 21:21:26 +0100) >> > > NAK, sorry. This breaks MIPS: > + malta > +(malta) common/cmd_bdinfo.c: In function 'do_bdinfo': > +(malta) common/cmd_bdinfo.c:328:34: error: 'bd_t' has no member named 'bi_dram' > +(malta) common/cmd_bdinfo.c:329:32: error: 'bd_t' has no member named 'bi_dram' > +(malta) make[2]: *** [common/cmd_bdinfo.o] Error 1 > +(malta) make[1]: *** [common] Error 2 > +(malta) make: *** [sub-make] Error 2 > Ouch, my fault. The change was misaligned by 14 lines. The MIPS and the AVR32 part looks almost the same in this section. I'll send a fixed PR this evening. > And it bisected down to: > 09bf969d927f73b083101fabb77e5130bec3eec1 is the first bad commit > commit 09bf969d927f73b083101fabb77e5130bec3eec1 > Author: Andreas Bießmann <andreas.devel@googlemail.com> > Date: Fri Feb 6 23:06:48 2015 +0100 > > avr32: add generic board support > > Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com> >
On Tue, Feb 17, 2015 at 04:48:36PM +0100, Andreas Bießmann wrote: > Hi Tom, > > On 02/17/2015 04:12 PM, Tom Rini wrote: > > On Mon, Feb 16, 2015 at 09:25:06PM +0100, Andreas Bießmann wrote: > > > >> Hi Tom, > >> > >> finally generic board support for avr32! > >> > >> The following changes since commit bd2a4888b123713adec271d6c8040ca9f609aa2f: > >> > >> sunxi: configs/sunxi-common.h: Enable CONFIG_CMD_PART (2015-02-11 19:43:45 -0500) > >> > >> are available in the git repository at: > >> > >> git://git.denx.de/u-boot-avr32.git master > >> > >> for you to fetch changes up to 4d3dada78ec402dc51e4198dda316301e0d99f35: > >> > >> atstk1002: enable generic board (2015-02-16 21:21:26 +0100) > >> > > > > NAK, sorry. This breaks MIPS: > > + malta > > +(malta) common/cmd_bdinfo.c: In function 'do_bdinfo': > > +(malta) common/cmd_bdinfo.c:328:34: error: 'bd_t' has no member named 'bi_dram' > > +(malta) common/cmd_bdinfo.c:329:32: error: 'bd_t' has no member named 'bi_dram' > > +(malta) make[2]: *** [common/cmd_bdinfo.o] Error 1 > > +(malta) make[1]: *** [common] Error 2 > > +(malta) make: *** [sub-make] Error 2 > > Ouch, my fault. The change was misaligned by 14 lines. The MIPS and the > AVR32 part looks almost the same in this section. I'll send a fixed PR > this evening. Great, thanks!