| Message ID | 38EFCC72-8244-4555-9A77-DFF12E08C09C@gmail.com |
|---|---|
| State | New |
| Headers | show |
On Dec 20, 2014, at 8:58 AM, FX <fxcoudert@gmail.com> wrote: > This patch below allows ubsan to run when libstdc++ is built but not installed (something which happens on darwin, in particular). This fixes all 658 ubsan failures when run in this particular configuration. > > OK to commit? Ok.
Mike and FX,
Shouldn't we also apply...
Author: fxcoudert
Date: Mon Dec 22 21:57:45 2014
New Revision: 219035
URL: https://gcc.gnu.org/viewcvs?rev=219035&root=gcc&view=rev
Log:
* lib/ubsan-dg.exp: Add library path for libstdc++.
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/lib/ubsan-dg.exp
to gcc-4_9-branch for 4.9.3?
https://gcc.gnu.org/ml/gcc-testresults/2015-02/msg01535.html
shows that we need it.
Jack
On Mon, Dec 22, 2014 at 12:02 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Dec 20, 2014, at 8:58 AM, FX <fxcoudert@gmail.com> wrote:
>> This patch below allows ubsan to run when libstdc++ is built but not installed (something which happens on darwin, in particular). This fixes all 658 ubsan failures when run in this particular configuration.
>>
>> OK to commit?
>
> Ok.
On Feb 13, 2015, at 2:24 PM, Jack Howarth <howarth.at.gcc@gmail.com> wrote: > Mike and FX, > Shouldn't we also apply… Ok. > Author: fxcoudert > Date: Mon Dec 22 21:57:45 2014 > New Revision: 219035 > > URL: https://gcc.gnu.org/viewcvs?rev=219035&root=gcc&view=rev > Log: > * lib/ubsan-dg.exp: Add library path for libstdc++. > > Modified: > trunk/gcc/testsuite/ChangeLog > trunk/gcc/testsuite/lib/ubsan-dg.exp > > to gcc-4_9-branch for 4.9.3? > > https://gcc.gnu.org/ml/gcc-testresults/2015-02/msg01535.html > > shows that we need it. > Jack > > On Mon, Dec 22, 2014 at 12:02 PM, Mike Stump <mikestump@comcast.net> wrote: >> On Dec 20, 2014, at 8:58 AM, FX <fxcoudert@gmail.com> wrote: >>> This patch below allows ubsan to run when libstdc++ is built but not installed (something which happens on darwin, in particular). This fixes all 658 ubsan failures when run in this particular configuration. >>> >>> OK to commit? >> >> Ok.
Index: gcc/testsuite/lib/ubsan-dg.exp =================================================================== --- gcc/testsuite/lib/ubsan-dg.exp (revision 218989) +++ gcc/testsuite/lib/ubsan-dg.exp (working copy) @@ -47,6 +47,7 @@ proc ubsan_link_flags { paths } { append flags " -B${gccpath}/libsanitizer/ubsan/ " append flags " -L${gccpath}/libsanitizer/ubsan/.libs" append ld_library_path ":${gccpath}/libsanitizer/ubsan/.libs" + append ld_library_path ":${gccpath}/libstdc++-v3/src/.libs" } } else { global tool_root_dir