| Message ID | 1423818347-3390-1-git-send-email-angelo.compagnucci@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
On Fri, Feb 13, 2015 at 10:05 AM, Angelo Compagnucci <angelo.compagnucci@gmail.com> wrote: > This patch adds the option to include xml libraries in python. > > Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> > --- > package/python/Config.in | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/package/python/Config.in b/package/python/Config.in > index 87defad..682a324 100644 > --- a/package/python/Config.in > +++ b/package/python/Config.in > @@ -114,6 +114,12 @@ config BR2_PACKAGE_PYTHON_SQLITE > help > SQLite database support > > +config BR2_PACKAGE_PYTHON_XML > + bool "xml module" > + select BR2_PACKAGE_PYTHON_PYEXPAT > + help > + Xml libraries for Python > + What about this existing option? config BR2_PACKAGE_PYTHON_PYEXPAT select BR2_PACKAGE_EXPAT bool "pyexpat" help pyexpat module for Python. Yegor > config BR2_PACKAGE_PYTHON_ZLIB > bool "zlib module" > select BR2_PACKAGE_ZLIB > -- > 1.9.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Yegor, 2015-02-13 10:31 GMT+01:00 Yegor Yefremov <yegorslists@googlemail.com>: >> >> +config BR2_PACKAGE_PYTHON_XML >> + bool "xml module" >> + select BR2_PACKAGE_PYTHON_PYEXPAT >> + help >> + Xml libraries for Python >> + > > What about this existing option? > > config BR2_PACKAGE_PYTHON_PYEXPAT > select BR2_PACKAGE_EXPAT > bool "pyexpat" > help > pyexpat module for Python. > > Yegor Whithout BR2_PACKAGE_PYTHON_XML there is no way you can know exactly when xml modules will be included or not without reading the configure script. Inedeed, python xml modules are included by the configure script only if pyexpat is enabled. BR2_PACKAGE_PYTHON_XML makes clear that if you want xml libraries, you should select pyexpat.
On Fri, Feb 13, 2015 at 10:39 AM, Angelo Compagnucci <angelo.compagnucci@gmail.com> wrote: > Hi Yegor, > > 2015-02-13 10:31 GMT+01:00 Yegor Yefremov <yegorslists@googlemail.com>: > >>> >>> +config BR2_PACKAGE_PYTHON_XML >>> + bool "xml module" >>> + select BR2_PACKAGE_PYTHON_PYEXPAT >>> + help >>> + Xml libraries for Python >>> + >> >> What about this existing option? >> >> config BR2_PACKAGE_PYTHON_PYEXPAT >> select BR2_PACKAGE_EXPAT >> bool "pyexpat" >> help >> pyexpat module for Python. >> >> Yegor > > Whithout BR2_PACKAGE_PYTHON_XML there is no way you can know exactly > when xml modules will be included or not without reading the configure > script. > Inedeed, python xml modules are included by the configure script only > if pyexpat is enabled. > > BR2_PACKAGE_PYTHON_XML makes clear that if you want xml libraries, you > should select pyexpat. Then the existing MACRO should be renamed. Though this implies renaming it in the existing packages, that have this option as dependency like jango etc. Yegor
Hi Yegor, 2015-02-13 10:47 GMT+01:00 Yegor Yefremov <yegorslists@googlemail.com>: > On Fri, Feb 13, 2015 at 10:39 AM, Angelo Compagnucci > <angelo.compagnucci@gmail.com> wrote: >> Hi Yegor, >> >> 2015-02-13 10:31 GMT+01:00 Yegor Yefremov <yegorslists@googlemail.com>: >> >>>> >>>> +config BR2_PACKAGE_PYTHON_XML >>>> + bool "xml module" >>>> + select BR2_PACKAGE_PYTHON_PYEXPAT >>>> + help >>>> + Xml libraries for Python >>>> + >>> >>> What about this existing option? >>> >>> config BR2_PACKAGE_PYTHON_PYEXPAT >>> select BR2_PACKAGE_EXPAT >>> bool "pyexpat" >>> help >>> pyexpat module for Python. >>> >>> Yegor >> >> Whithout BR2_PACKAGE_PYTHON_XML there is no way you can know exactly >> when xml modules will be included or not without reading the configure >> script. >> Inedeed, python xml modules are included by the configure script only >> if pyexpat is enabled. >> >> BR2_PACKAGE_PYTHON_XML makes clear that if you want xml libraries, you >> should select pyexpat. > > Then the existing MACRO should be renamed. Though this implies > renaming it in the existing packages, that have this option as > dependency like jango etc. Yes, probably renaming BR2_PACKAGE_PYTHON_PYEXPAT to BR2_PACKAGE_PYTHON_XML makes sense, but it's an intrusive changing. I'm offering to volunteer, but I will wait for more comments. Sincerely, Angelo > > Yegor
Dear Angelo Compagnucci, On Fri, 13 Feb 2015 10:53:46 +0100, Angelo Compagnucci wrote: > > Then the existing MACRO should be renamed. Though this implies > > renaming it in the existing packages, that have this option as > > dependency like jango etc. > > Yes, probably renaming BR2_PACKAGE_PYTHON_PYEXPAT to > BR2_PACKAGE_PYTHON_XML makes sense, but it's an intrusive changing. > I'm offering to volunteer, but I will wait for more comments. Indeed, the option name is a bit weird. But renaming options is also a bit annoying. What about only renaming the prompt of the option instead? Best regards, Thomas
Dear Thomas Petazzoni, 2015-02-13 17:59 GMT+01:00 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>: > Dear Angelo Compagnucci, > > On Fri, 13 Feb 2015 10:53:46 +0100, Angelo Compagnucci wrote: > >> > Then the existing MACRO should be renamed. Though this implies >> > renaming it in the existing packages, that have this option as >> > dependency like jango etc. >> >> Yes, probably renaming BR2_PACKAGE_PYTHON_PYEXPAT to >> BR2_PACKAGE_PYTHON_XML makes sense, but it's an intrusive changing. >> I'm offering to volunteer, but I will wait for more comments. > > Indeed, the option name is a bit weird. But renaming options is also a > bit annoying. What about only renaming the prompt of the option instead? Why not! I think solves both problems and makes clear that BR2_PACKAGE_PYTHON_PYEXPAT enables all python xml modules. I'll prepare a patch in minutes! > > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
diff --git a/package/python/Config.in b/package/python/Config.in index 87defad..682a324 100644 --- a/package/python/Config.in +++ b/package/python/Config.in @@ -114,6 +114,12 @@ config BR2_PACKAGE_PYTHON_SQLITE help SQLite database support +config BR2_PACKAGE_PYTHON_XML + bool "xml module" + select BR2_PACKAGE_PYTHON_PYEXPAT + help + Xml libraries for Python + config BR2_PACKAGE_PYTHON_ZLIB bool "zlib module" select BR2_PACKAGE_ZLIB
This patch adds the option to include xml libraries in python. Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com> --- package/python/Config.in | 6 ++++++ 1 file changed, 6 insertions(+)