diff mbox

[Fortran,OOP] PR 64230: [4.9/5 Regression] Invalid memory reference in a compiler-generated finalizer for allocatable component

Message ID CAKwh3qgUY9HhQMKdmk1VrFQB7WXQtjUOvE9JDMdps3z_p-=ojQ@mail.gmail.com
State New
Headers show

Commit Message

Janus Weil Jan. 27, 2015, 6:20 p.m. UTC 
> On Tue, Jan 27, 2015 at 10:24:47AM +0100, Andreas Schwab wrote:
>>
>> > 2015-01-19  Janus Weil  <janus@gcc.gnu.org>
>> >
>> >     PR fortran/64230
>> >     * gfortran.dg/class_allocate_18.f90: Extended.
>>
>> FAIL: gfortran.dg/class_allocate_18.f90   -O0  (test for excess errors)
>> Excess errors:
>> /usr/ia64-suse-linux/bin/ld: cannot find -lubsan

Sorry for the breakage, guys!


2015-01-27 10:30 GMT+01:00 Jakub Jelinek <jakub@redhat.com>:
> Yeah, if you want to add ubsan tests, you need to add gfortran.dg/ubsan/
> directory and hack up ubsan.exp in there

Thanks for the remark, I was suspecting something like that. However,
for this case it's not really worth the hassle. In fact the test case
does not really need the sanitizer and should also work without it. So
I'll just remove the -fsanitize option:

 !


Cheers,
Janus

Comments

Jakub Jelinek Jan. 27, 2015, 6:23 p.m. UTC | #1 
On Tue, Jan 27, 2015 at 07:20:10PM +0100, Janus Weil wrote:
> 2015-01-27 10:30 GMT+01:00 Jakub Jelinek <jakub@redhat.com>:
> > Yeah, if you want to add ubsan tests, you need to add gfortran.dg/ubsan/
> > directory and hack up ubsan.exp in there
> 
> Thanks for the remark, I was suspecting something like that. However,
> for this case it's not really worth the hassle. In fact the test case
> does not really need the sanitizer and should also work without it. So
> I'll just remove the -fsanitize option:
> 
> Index: gcc/testsuite/gfortran.dg/class_allocate_18.f90
> ===================================================================
> --- gcc/testsuite/gfortran.dg/class_allocate_18.f90    (Revision 220180)
> +++ gcc/testsuite/gfortran.dg/class_allocate_18.f90    (Arbeitskopie)
> @@ -1,5 +1,4 @@
>  ! { dg-do run }
> -! { dg-options "-fsanitize=undefined" }
>  !
>  ! PR 64230: [4.9/5 Regression] Invalid memory reference in a
> compiler-generated finalizer for allocatable component
>  !

LGTM.

	Jakub
Janus Weil Jan. 27, 2015, 6:57 p.m. UTC | #2 
2015-01-27 19:23 GMT+01:00 Jakub Jelinek <jakub@redhat.com>:
> On Tue, Jan 27, 2015 at 07:20:10PM +0100, Janus Weil wrote:
>> 2015-01-27 10:30 GMT+01:00 Jakub Jelinek <jakub@redhat.com>:
>> > Yeah, if you want to add ubsan tests, you need to add gfortran.dg/ubsan/
>> > directory and hack up ubsan.exp in there
>>
>> Thanks for the remark, I was suspecting something like that. However,
>> for this case it's not really worth the hassle. In fact the test case
>> does not really need the sanitizer and should also work without it. So
>> I'll just remove the -fsanitize option:
>>
>> Index: gcc/testsuite/gfortran.dg/class_allocate_18.f90
>> ===================================================================
>> --- gcc/testsuite/gfortran.dg/class_allocate_18.f90    (Revision 220180)
>> +++ gcc/testsuite/gfortran.dg/class_allocate_18.f90    (Arbeitskopie)
>> @@ -1,5 +1,4 @@
>>  ! { dg-do run }
>> -! { dg-options "-fsanitize=undefined" }
>>  !
>>  ! PR 64230: [4.9/5 Regression] Invalid memory reference in a
>> compiler-generated finalizer for allocatable component
>>  !
>
> LGTM.

Good, committed as r220181. Since I had already backported the
original patch to 4.9 yesterday, I'll do the same there ...

Cheers,
Janus
diff mbox

Patch

Index: gcc/testsuite/gfortran.dg/class_allocate_18.f90
===================================================================
--- gcc/testsuite/gfortran.dg/class_allocate_18.f90    (Revision 220180)
+++ gcc/testsuite/gfortran.dg/class_allocate_18.f90    (Arbeitskopie)
@@ -1,5 +1,4 @@ 
 ! { dg-do run }
-! { dg-options "-fsanitize=undefined" }
 !
 ! PR 64230: [4.9/5 Regression] Invalid memory reference in a
compiler-generated finalizer for allocatable component