| Message ID | 5461C1CF.4090409@huawei.com |
|---|---|
| State | Accepted |
| Commit | 17e276ee208abbc61c8f089040af02ee4dd27115 |
| Headers | show |
On 11 November 2014 at 08:59, wangyufen <wangyufen@huawei.com> wrote:
> mknod() in glibc/eglibc will check the argument, like this,
Applied, thanks!
diff --git a/libc/sysdeps/linux/common/mknod.c b/libc/sysdeps/linux/common/mknod.c index 416cab6..29e21ac 100644 --- a/libc/sysdeps/linux/common/mknod.c +++ b/libc/sysdeps/linux/common/mknod.c @@ -24,6 +24,10 @@ int mknod(const char *path, mode_t mode, dev_t dev) /* We must convert the value to dev_t type used by the kernel. */ k_dev = (dev) & ((1ULL << 32) - 1); + if (k_dev != dev) { + __set_errno (EINVAL); + return -1; + } return INLINE_SYSCALL(mknod, 3, path, mode, (unsigned int)k_dev); } #endif
mknod() in glibc/eglibc will check the argument, like this, ... if (k_dev != dev) { __set_errno (EINVAL); return -1; } ... So add argument check in uclibc's mknod() too. Signed-off-by: Wang Yufen <wangyufen@huawei.com> --- libc/sysdeps/linux/common/mknod.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)