diff mbox

drm/tegra: Fix copypasta in host1x_reloc_copy_from_user

Message ID 1421807855-27853-1-git-send-email-davidu@nvidia.com
State Not Applicable, archived
Headers show

Commit Message

David Ung Jan. 21, 2015, 2:37 a.m. UTC
Fix copypasta bug for function host1x_reloc_copy_from_user.

Signed-off-by: David Ung <davidu@nvidia.com>
---
 drivers/gpu/drm/tegra/drm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thierry Reding Jan. 23, 2015, 11:24 a.m. UTC | #1
On Tue, Jan 20, 2015 at 06:37:35PM -0800, David Ung wrote:
> Fix copypasta bug for function host1x_reloc_copy_from_user.
> 
> Signed-off-by: David Ung <davidu@nvidia.com>
> ---
>  drivers/gpu/drm/tegra/drm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I've applied this with a reworded commit message and added a proper
Fixes: tag. It should also go to stable because the offending commit was
merged in v3.17. Yay for not having automated test procedures that could
have easily caught this...

Thierry
diff mbox

Patch

diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index d4f8275..d8c9fb7 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -190,7 +190,7 @@  static int host1x_reloc_copy_from_user(struct host1x_reloc *dest,
 	if (err < 0)
 		return err;
 
-	err = get_user(dest->target.offset, &src->cmdbuf.offset);
+	err = get_user(dest->target.offset, &src->target.offset);
 	if (err < 0)
 		return err;