Message ID | 1421920699-26556-2-git-send-email-dborkman@redhat.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On 01/22/15 at 10:58am, Daniel Borkmann wrote: > As soon as we've found a matching handle in basic_get(), we can > return it. There's no need to continue walking until the end of > a filter chain, since they are unique anyway. > > Signed-off-by: Daniel Borkmann <dborkman@redhat.com> > Acked-by: Jiri Pirko <jiri@resnulli.us> > Cc: Thomas Graf <tgraf@suug.ch> Acked-by: Thomas Graf <tgraf@suug.ch> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c index 5aed341..fc399db 100644 --- a/net/sched/cls_basic.c +++ b/net/sched/cls_basic.c @@ -65,9 +65,12 @@ static unsigned long basic_get(struct tcf_proto *tp, u32 handle) if (head == NULL) return 0UL; - list_for_each_entry(f, &head->flist, link) - if (f->handle == handle) + list_for_each_entry(f, &head->flist, link) { + if (f->handle == handle) { l = (unsigned long) f; + break; + } + } return l; }