diff mbox

[v5,3/7] gpio/xilinx: Add support for X86 Arch

Message ID 1418831474-24428-4-git-send-email-ricardo.ribalda@gmail.com
State New, archived
Headers show

Commit Message

Ricardo Ribalda Delgado Dec. 17, 2014, 3:51 p.m. UTC 
Core can be accessed via PCIe on X86 platform.
This patch also allows the driver to be used as module.

Acked-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/gpio/Kconfig       | 4 ++--
 drivers/gpio/gpio-xilinx.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Linus Walleij Jan. 12, 2015, 9:24 a.m. UTC | #1 
On Wed, Dec 17, 2014 at 4:51 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:

> Core can be accessed via PCIe on X86 platform.
> This patch also allows the driver to be used as module.
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

PCIe on x86, using device tree? The ACPI people are just gonna love this.

Patch applied, anyway. DT on x86 is not unheard of.

>  config GPIO_XILINX
> -       bool "Xilinx GPIO support"
> -       depends on PPC_OF || MICROBLAZE || ARCH_ZYNQ
> +       tristate "Xilinx GPIO support"
> +       depends on OF_GPIO && (PPC_OF || MICROBLAZE || ARCH_ZYNQ || ARCH_X86)

Maybe you want to add COMPILE_TEST too?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ricardo Ribalda Delgado Jan. 12, 2015, 9:31 a.m. UTC | #2 
Hello

On Mon, Jan 12, 2015 at 10:24 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Wed, Dec 17, 2014 at 4:51 PM, Ricardo Ribalda Delgado
> <ricardo.ribalda@gmail.com> wrote:
>
>> Core can be accessed via PCIe on X86 platform.
>> This patch also allows the driver to be used as module.
>>
>> Acked-by: Michal Simek <michal.simek@xilinx.com>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>
> PCIe on x86, using device tree? The ACPI people are just gonna love this.

>
> Patch applied, anyway. DT on x86 is not unheard of.
>
>>  config GPIO_XILINX
>> -       bool "Xilinx GPIO support"
>> -       depends on PPC_OF || MICROBLAZE || ARCH_ZYNQ
>> +       tristate "Xilinx GPIO support"
>> +       depends on OF_GPIO && (PPC_OF || MICROBLAZE || ARCH_ZYNQ || ARCH_X86)
>
> Maybe you want to add COMPILE_TEST too?

Up to you

>
> Yours,
> Linus Walleij
Paul Bolle Jan. 13, 2015, 9:02 a.m. UTC | #3 
On Wed, 2014-12-17 at 16:51 +0100, Ricardo Ribalda Delgado wrote:
> Core can be accessed via PCIe on X86 platform.
> This patch also allows the driver to be used as module.
> 
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>  drivers/gpio/Kconfig       | 4 ++--
>  drivers/gpio/gpio-xilinx.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

This patch became c586b3075d5b ("gpio/xilinx: Add support for X86 Arch")
in today's linux-next (next-20150113). I noticed because a script I use
to check linux-next spotted a problem in it.

> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 414d055..b17d226 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -366,8 +366,8 @@ config GPIO_XGENE
>  	  here to enable the GFC GPIO functionality.
>  
>  config GPIO_XILINX
> -	bool "Xilinx GPIO support"
> -	depends on PPC_OF || MICROBLAZE || ARCH_ZYNQ
> +	tristate "Xilinx GPIO support"
> +	depends on OF_GPIO && (PPC_OF || MICROBLAZE || ARCH_ZYNQ || ARCH_X86)

There's no Kconfig symbol "ARCH_X86". Did you actually mean "X86"?

>  	help
>  	  Say yes here to support the Xilinx FPGA GPIO device
>  
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index c7ed92b..554060a 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -30,7 +30,7 @@
>  #define XGPIO_CHANNEL_OFFSET	0x8
>  
>  /* Read/Write access to the GPIO registers */
> -#ifdef CONFIG_ARCH_ZYNQ
> +#if defined(CONFIG_ARCH_ZYNQ) || defined(CONFIG_X86)

Yes, you probably did want just "X86".

>  # define xgpio_readreg(offset)		readl(offset)
>  # define xgpio_writereg(offset, val)	writel(val, offset)
>  #else


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ricardo Ribalda Delgado Jan. 13, 2015, 9:04 a.m. UTC | #4 
Hello Paul

Thanks for noticing

Shall I send the patch or you want to do it yourself?


Thanks again!

On Tue, Jan 13, 2015 at 10:02 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Wed, 2014-12-17 at 16:51 +0100, Ricardo Ribalda Delgado wrote:
>> Core can be accessed via PCIe on X86 platform.
>> This patch also allows the driver to be used as module.
>>
>> Acked-by: Michal Simek <michal.simek@xilinx.com>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>> ---
>>  drivers/gpio/Kconfig       | 4 ++--
>>  drivers/gpio/gpio-xilinx.c | 2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> This patch became c586b3075d5b ("gpio/xilinx: Add support for X86 Arch")
> in today's linux-next (next-20150113). I noticed because a script I use
> to check linux-next spotted a problem in it.
>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 414d055..b17d226 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -366,8 +366,8 @@ config GPIO_XGENE
>>         here to enable the GFC GPIO functionality.
>>
>>  config GPIO_XILINX
>> -     bool "Xilinx GPIO support"
>> -     depends on PPC_OF || MICROBLAZE || ARCH_ZYNQ
>> +     tristate "Xilinx GPIO support"
>> +     depends on OF_GPIO && (PPC_OF || MICROBLAZE || ARCH_ZYNQ || ARCH_X86)
>
> There's no Kconfig symbol "ARCH_X86". Did you actually mean "X86"?
>
>>       help
>>         Say yes here to support the Xilinx FPGA GPIO device
>>
>> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
>> index c7ed92b..554060a 100644
>> --- a/drivers/gpio/gpio-xilinx.c
>> +++ b/drivers/gpio/gpio-xilinx.c
>> @@ -30,7 +30,7 @@
>>  #define XGPIO_CHANNEL_OFFSET 0x8
>>
>>  /* Read/Write access to the GPIO registers */
>> -#ifdef CONFIG_ARCH_ZYNQ
>> +#if defined(CONFIG_ARCH_ZYNQ) || defined(CONFIG_X86)
>
> Yes, you probably did want just "X86".
>
>>  # define xgpio_readreg(offset)               readl(offset)
>>  # define xgpio_writereg(offset, val) writel(val, offset)
>>  #else
>
>
> Paul Bolle
>
Paul Bolle Jan. 13, 2015, 9:20 a.m. UTC | #5 
Hi Ricardo,

On Tue, 2015-01-13 at 10:04 +0100, Ricardo Ribalda Delgado wrote:
> Thanks for noticing
> 
> Shall I send the patch or you want to do it yourself?

I rather prefer you do it, even if it looks trivial.

Changing that line to
    [...] || X86)

will apparently enable a bit of code for the first time on x86. Code
that I know nothing about. I don't even know how to build or test it.
See, I've submitted such obviously correct and trivial changes before,
only to receive fan mail from the kbuild test robot the very next day. I
hope to not repeat that experience.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Jan. 15, 2015, 4:13 p.m. UTC | #6 
On Tue, Jan 13, 2015 at 10:02 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Wed, 2014-12-17 at 16:51 +0100, Ricardo Ribalda Delgado wrote:
>> Core can be accessed via PCIe on X86 platform.
>> This patch also allows the driver to be used as module.
>>
>> Acked-by: Michal Simek <michal.simek@xilinx.com>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>> ---
>>  drivers/gpio/Kconfig       | 4 ++--
>>  drivers/gpio/gpio-xilinx.c | 2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> This patch became c586b3075d5b ("gpio/xilinx: Add support for X86 Arch")
> in today's linux-next (next-20150113). I noticed because a script I use
> to check linux-next spotted a problem in it.

Yes the topic line was way too long so I just took my axe
and chopped of a string.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 414d055..b17d226 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -366,8 +366,8 @@  config GPIO_XGENE
 	  here to enable the GFC GPIO functionality.
 
 config GPIO_XILINX
-	bool "Xilinx GPIO support"
-	depends on PPC_OF || MICROBLAZE || ARCH_ZYNQ
+	tristate "Xilinx GPIO support"
+	depends on OF_GPIO && (PPC_OF || MICROBLAZE || ARCH_ZYNQ || ARCH_X86)
 	help
 	  Say yes here to support the Xilinx FPGA GPIO device
 
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index c7ed92b..554060a 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -30,7 +30,7 @@ 
 #define XGPIO_CHANNEL_OFFSET	0x8
 
 /* Read/Write access to the GPIO registers */
-#ifdef CONFIG_ARCH_ZYNQ
+#if defined(CONFIG_ARCH_ZYNQ) || defined(CONFIG_X86)
 # define xgpio_readreg(offset)		readl(offset)
 # define xgpio_writereg(offset, val)	writel(val, offset)
 #else