| Message ID | 1419717508-11627-11-git-send-email-romain.naour@openwide.fr |
|---|---|
| State | Rejected |
| Headers | show |
Dear Romain Naour, On Sat, 27 Dec 2014 22:58:28 +0100, Romain Naour wrote: > Signed-off-by: Romain Naour <romain.naour@openwide.fr> > --- > package/dvb-apps/0004-Makefile-remove-test.patch | 27 ++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 package/dvb-apps/0004-Makefile-remove-test.patch Ok, now I understand why patch 09/10 was not working. If patch 09/10 needs patch 10/10 to work, then patch 10/10 needs to be *before* patch 09/10 in the series, or be squashed into it. Patch rejected, please resend an updated version. Also, if you could send to upstream dvb-apps those patches (and the other ones we have), it would be great. Thanks, Thomas
Hi Thomas, Le 02/01/2015 13:26, Thomas Petazzoni a écrit : > Dear Romain Naour, > > On Sat, 27 Dec 2014 22:58:28 +0100, Romain Naour wrote: >> Signed-off-by: Romain Naour <romain.naour@openwide.fr> >> --- >> package/dvb-apps/0004-Makefile-remove-test.patch | 27 ++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> create mode 100644 package/dvb-apps/0004-Makefile-remove-test.patch > > Ok, now I understand why patch 09/10 was not working. > > If patch 09/10 needs patch 10/10 to work, then patch 10/10 needs to be > *before* patch 09/10 in the series, or be squashed into it. My bad, I haven't reordered these patches. I have sent them in the same order I commited locally... Ok, I'll squash them. > > Patch rejected, please resend an updated version. > > Also, if you could send to upstream dvb-apps those patches (and the > other ones we have), it would be great. > Ok, I'll send patches upstream. Best regards, Romain
diff --git a/package/dvb-apps/0004-Makefile-remove-test.patch b/package/dvb-apps/0004-Makefile-remove-test.patch new file mode 100644 index 0000000..45bfad9 --- /dev/null +++ b/package/dvb-apps/0004-Makefile-remove-test.patch @@ -0,0 +1,27 @@ +From c578772d6abc5fdf3ec83f632c371373e5baf9f1 Mon Sep 17 00:00:00 2001 +From: Romain Naour <romain.naour@openwide.fr> +Date: Fri, 26 Dec 2014 01:04:58 +0100 +Subject: [PATCH] Makefile: remove test + +Tests needs static libraries, remove them for shared only build. + +Signed-off-by: Romain Naour <romain.naour@openwide.fr> +--- + Makefile | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/Makefile b/Makefile +index 65a2273..105c460 100644 +--- a/Makefile ++++ b/Makefile +@@ -10,7 +10,6 @@ DVB_API_MINOR := $(word 3, $(shell grep -m1 "DVB_API_VERSION_MINOR" $(VERSION_FI + + all clean install: + $(MAKE) -C lib $@ +- $(MAKE) -C test $@ + $(MAKE) -C util $@ + + update: +-- +1.9.3 +
Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- package/dvb-apps/0004-Makefile-remove-test.patch | 27 ++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 package/dvb-apps/0004-Makefile-remove-test.patch