| Message ID | 1419746510.4496.2.camel@phoenix |
|---|---|
| State | New, archived |
| Headers | show |
On 28/12/14 06:01, Axel Lin wrote: > Signed-off-by: Axel Lin <axel.lin@ingics.com> Thanks, both patches Acked-by: James Hogan <james.hogan@imgtec.com> Note that the previous off-by-one behaviour should be harmless since the SoC IO memory region is unmapped on Meta (i.e. the ioremap becomes a no-op as the whole of IO memory is accessible with normal memory accesses regardless of MMU). Cheers James > --- > drivers/gpio/gpio-tz1090-pdc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-tz1090-pdc.c b/drivers/gpio/gpio-tz1090-pdc.c > index d753622..ede7e40 100644 > --- a/drivers/gpio/gpio-tz1090-pdc.c > +++ b/drivers/gpio/gpio-tz1090-pdc.c > @@ -190,7 +190,7 @@ static int tz1090_pdc_gpio_probe(struct platform_device *pdev) > > /* Ioremap the registers */ > priv->reg = devm_ioremap(&pdev->dev, res_regs->start, > - res_regs->end - res_regs->start); > + resource_size(res_regs)); > if (!priv->reg) { > dev_err(&pdev->dev, "unable to ioremap registers\n"); > return -ENOMEM; >
diff --git a/drivers/gpio/gpio-tz1090-pdc.c b/drivers/gpio/gpio-tz1090-pdc.c index d753622..ede7e40 100644 --- a/drivers/gpio/gpio-tz1090-pdc.c +++ b/drivers/gpio/gpio-tz1090-pdc.c @@ -190,7 +190,7 @@ static int tz1090_pdc_gpio_probe(struct platform_device *pdev) /* Ioremap the registers */ priv->reg = devm_ioremap(&pdev->dev, res_regs->start, - res_regs->end - res_regs->start); + resource_size(res_regs)); if (!priv->reg) { dev_err(&pdev->dev, "unable to ioremap registers\n"); return -ENOMEM;
Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/gpio/gpio-tz1090-pdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)