diff mbox

[4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

Message ID DUB118-W39F20F36D26B91274E4A4E4770@phx.gbl
State New
Headers show

Commit Message

Bernd Edlinger Nov. 21, 2014, 6:19 p.m. UTC 
Aehm Kirill,

excuse me please, but if I do

autogen Makefile.def


I get this from svn diff


svn blame Makefile.in points to:

r217498 | kyukhin | 2014-11-13 15:03:17 +0100 (Thu, 13 Nov 2014) | 110 lines

[PATCH 2/4] OpenMP 4.0 offloading to Intel MIC: liboffloadmic.

    * Makefile.def: Add liboffloadmic to target_modules.  Make
    liboffloadmic depend on libgomp's configure, libstdc++ and libgcc.
    * Makefile.in: Regenerate.
    * configure: Regenerate.
    * configure.ac: Add liboffloadmic to target binaries.
    Restrict liboffloadmic for POSIX and i*86, and x86_64 architectures.
    Add liboffloadmic to noconfig list when C++ is not supported.


so, did you really regenerate Makefile.in in that patch, or am I missing something ?


Regards,
Bernd.

Comments

Ilya Verbin Nov. 21, 2014, 6:44 p.m. UTC | #1 
Hi,

On 21 Nov 19:19, Bernd Edlinger wrote:
> so, did you really regenerate Makefile.in in that patch, or am I missing something ?

You're right.  This patch was rebased so many times, that we may forget to
regenerate it before committing.

Do you plan to submit any patch for Makefile.in?
Or should I post this change separately for review? (with regtesting)

  -- Ilya
Bernd Edlinger Nov. 21, 2014, 6:54 p.m. UTC | #2 
Hi Ilya,

On Fri, 21 Nov 2014 21:44:40, Ilya Verbin wrote:
>
> Hi,
>
> On 21 Nov 19:19, Bernd Edlinger wrote:
>> so, did you really regenerate Makefile.in in that patch, or am I missing something ?
>
> You're right. This patch was rebased so many times, that we may forget to
> regenerate it before committing.
>
> Do you plan to submit any patch for Makefile.in?
> Or should I post this change separately for review? (with regtesting)
>
> -- Ilya


No, at least not immediately, so I would prefer if you go ahead with your patch ASAP.


Thanks,
Bernd.
diff mbox

Patch

Index: Makefile.in
===================================================================
--- Makefile.in    (revision 217890)
+++ Makefile.in    (working copy)
@@ -35238,9 +35238,6 @@ 
     $(SHELL) $(srcdir)/mkinstalldirs $(TARGET_SUBDIR)/liboffloadmic ; \
     $(NORMAL_TARGET_EXPORTS)  \
     echo Configuring in $(TARGET_SUBDIR)/liboffloadmic; \
-     \
-    this_target="${target_alias}"; \
-     \
     cd "$(TARGET_SUBDIR)/liboffloadmic" || exit 1; \
     case $(srcdir) in \
       /* | [A-Za-z]:[\\/]*) topdir=$(srcdir) ;; \
@@ -35248,14 +35245,12 @@ 
         sed -e 's,\./,,g' -e 's,[^/]*/,../,g' `$(srcdir) ;; \
     esac; \
     module_srcdir=liboffloadmic; \
-    srcdiroption="--srcdir=$${topdir}/liboffloadmic"; \
-    libsrcdir="$$s/liboffloadmic"; \
     rm -f no-such-file || : ; \
     CONFIG_SITE=no-such-file $(SHELL) \
       $$s/$$module_srcdir/configure \
       --srcdir=$${topdir}/$$module_srcdir \
       $(TARGET_CONFIGARGS) --build=${build_alias} --host=${target_alias} \
-      --target=$${this_target} $${srcdiroption} @extra_liboffloadmic_configure_flags@ \
+      --target=${target_alias} @extra_liboffloadmic_configure_flags@ \
       || exit 1
 @endif target-liboffloadmic