diff mbox

Set goarch to ppc64le where needed for gccgo testing

Message ID 546CB0CF.20005@linux.vnet.ibm.com
State New
Headers show

Commit Message

Lynn A. Boger Nov. 19, 2014, 3:01 p.m. UTC 
Hi,

This change goes along with the change to the GOARCH setting in gccgo 
for ppc64le which will be done in gofrontend.  The description for that 
change is here: 
https://groups.google.com/forum/#!topic/gofrontend-dev/ocEttrpsw-s

This change has been bootstrapped and tested along with the above change 
to gofrontend on ppc, ppc64, and ppc64le.

2014-11-19  Lynn Boger <laboger@linux.vnet.ibm.com>
         * gcc/testsuite/go.test/go-test.exp:  Add case for ppc64le 
goarch value for go testing

Comments

Segher Boessenkool Nov. 19, 2014, 4:08 p.m. UTC | #1 
On Wed, Nov 19, 2014 at 09:01:35AM -0600, Lynn A. Boger wrote:
> +       "powerpc-*-*" {
> +           set goarch "ppc"
>         }
> +       "powerpc64-*-*" {
> +           set goarch "ppc64"
> +       }
> +       "powerpc64le-*-*" {
> +           set goarch "ppc64le"
> +       }

I don't think this will work with e.g.
  make check RUNTESTFLAGS="--target_board=unix'{-m64,-m32}'"
?


Segher
Lynn A. Boger Nov. 19, 2014, 7:02 p.m. UTC | #2 
Sorry.  I ran 'make check-go' assuming it ran both m32 and m64 on a 
ppc64 machine.  I'll fix and retest.

On 11/19/2014 10:08 AM, Segher Boessenkool wrote:
> On Wed, Nov 19, 2014 at 09:01:35AM -0600, Lynn A. Boger wrote:
>> +       "powerpc-*-*" {
>> +           set goarch "ppc"
>>          }
>> +       "powerpc64-*-*" {
>> +           set goarch "ppc64"
>> +       }
>> +       "powerpc64le-*-*" {
>> +           set goarch "ppc64le"
>> +       }
> I don't think this will work with e.g.
>    make check RUNTESTFLAGS="--target_board=unix'{-m64,-m32}'"
> ?
>
>
> Segher
>
>
>
diff mbox

Patch

Index: gcc/testsuite/go.test/go-test.exp
===================================================================
--- gcc/testsuite/go.test/go-test.exp   (revision 217507)
+++ gcc/testsuite/go.test/go-test.exp   (working copy)
@@ -237,13 +237,15 @@  proc go-set-goarch { } {
                 return ""
             }
         }
-       "powerpc*-*-*" {
-           if [check_effective_target_ilp32] {
-               set goarch "ppc"
-           } else {
-               set goarch "ppc64"
-           }
+       "powerpc-*-*" {
+           set goarch "ppc"
         }
+       "powerpc64-*-*" {
+           set goarch "ppc64"
+       }
+       "powerpc64le-*-*" {
+           set goarch "ppc64le"
+       }
         "s390-*-*" {
             set goarch "s390"
         }