Message ID | 1412930455-40512-1-git-send-email-Vincent.Riera@imgtec.com |
---|---|
State | Superseded |
Headers | show |
Dear Vicente Olivert Riera, On Fri, 10 Oct 2014 09:40:55 +0100, Vicente Olivert Riera wrote: > kmod can fail to build in systems which have old automake versions like > CentOS 6.5, for instance. It will cause an error like this one: > > /buildroot/output/build/kmod-18/build-aux/missing: line 81: > aclocal-1.14: command not found > > Adding host-automake as a dependency fixes the problem. > > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> > Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com> > --- > package/kmod/kmod.mk | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk > index 1f170dd..c0212bb 100644 > --- a/package/kmod/kmod.mk > +++ b/package/kmod/kmod.mk > @@ -8,8 +8,8 @@ KMOD_VERSION = 18 > KMOD_SOURCE = kmod-$(KMOD_VERSION).tar.xz > KMOD_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kmod > KMOD_INSTALL_STAGING = YES > -KMOD_DEPENDENCIES = host-pkgconf > -HOST_KMOD_DEPENDENCIES = host-pkgconf > +KMOD_DEPENDENCIES = host-automake host-pkgconf > +HOST_KMOD_DEPENDENCIES = host-automake host-pkgconf > > # license info for libkmod only, conditionally add more below > KMOD_LICENSE = LGPLv2.1+ This seems wrong. Why not use KMOD_AUTORECONF = YES instead? Thomas
Dear Thomas Petazzoni, On 10/10/2014 10:06 AM, Thomas Petazzoni wrote: > Dear Vicente Olivert Riera, > > On Fri, 10 Oct 2014 09:40:55 +0100, Vicente Olivert Riera wrote: >> kmod can fail to build in systems which have old automake versions like >> CentOS 6.5, for instance. It will cause an error like this one: >> >> /buildroot/output/build/kmod-18/build-aux/missing: line 81: >> aclocal-1.14: command not found >> >> Adding host-automake as a dependency fixes the problem. >> >> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> >> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com> >> --- >> package/kmod/kmod.mk | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk >> index 1f170dd..c0212bb 100644 >> --- a/package/kmod/kmod.mk >> +++ b/package/kmod/kmod.mk >> @@ -8,8 +8,8 @@ KMOD_VERSION = 18 >> KMOD_SOURCE = kmod-$(KMOD_VERSION).tar.xz >> KMOD_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kmod >> KMOD_INSTALL_STAGING = YES >> -KMOD_DEPENDENCIES = host-pkgconf >> -HOST_KMOD_DEPENDENCIES = host-pkgconf >> +KMOD_DEPENDENCIES = host-automake host-pkgconf >> +HOST_KMOD_DEPENDENCIES = host-automake host-pkgconf >> >> # license info for libkmod only, conditionally add more below >> KMOD_LICENSE = LGPLv2.1+ > > This seems wrong. Why not use KMOD_AUTORECONF = YES instead? I have tried it and it fails: >>> kmod 18 Autoreconfiguring libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `build-aux'. libtoolize: copying file `build-aux/ltmain.sh' libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'. libtoolize: copying file `m4/libtool.m4' libtoolize: copying file `m4/ltoptions.m4' libtoolize: copying file `m4/ltsugar.m4' libtoolize: copying file `m4/ltversion.m4' libtoolize: copying file `m4/lt~obsolete.m4' libkmod/docs/gtk-doc.make:270: error: HAVE_GTK_DOC does not appear in AM_CONDITIONAL libkmod/docs/Makefile.am:33: 'libkmod/docs/gtk-doc.make' included from here And also, if the kmod-0002-add-backup-implementation-of-be32toh.patch modifies the configure.ac file, and there is no KMOD_AUTORECONF = YES in the kmod.mk file, why don't we clean that patch by removing the configure.ac bit? Regards,
Hi Vicente, Thomas, all, On Fri, Oct 10, 2014 at 11:15 AM, Vicente Olivert Riera <Vincent.Riera@imgtec.com> wrote: > Dear Thomas Petazzoni, > > > On 10/10/2014 10:06 AM, Thomas Petazzoni wrote: >> >> Dear Vicente Olivert Riera, >> >> On Fri, 10 Oct 2014 09:40:55 +0100, Vicente Olivert Riera wrote: >>> >>> kmod can fail to build in systems which have old automake versions like >>> CentOS 6.5, for instance. It will cause an error like this one: >>> >>> /buildroot/output/build/kmod-18/build-aux/missing: line 81: >>> aclocal-1.14: command not found >>> >>> Adding host-automake as a dependency fixes the problem. >>> >>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> >>> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com> >>> --- >>> package/kmod/kmod.mk | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk >>> index 1f170dd..c0212bb 100644 >>> --- a/package/kmod/kmod.mk >>> +++ b/package/kmod/kmod.mk >>> @@ -8,8 +8,8 @@ KMOD_VERSION = 18 >>> KMOD_SOURCE = kmod-$(KMOD_VERSION).tar.xz >>> KMOD_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kmod >>> KMOD_INSTALL_STAGING = YES >>> -KMOD_DEPENDENCIES = host-pkgconf >>> -HOST_KMOD_DEPENDENCIES = host-pkgconf >>> +KMOD_DEPENDENCIES = host-automake host-pkgconf >>> +HOST_KMOD_DEPENDENCIES = host-automake host-pkgconf >>> >>> # license info for libkmod only, conditionally add more below >>> KMOD_LICENSE = LGPLv2.1+ >> >> >> This seems wrong. Why not use KMOD_AUTORECONF = YES instead? > > > I have tried it and it fails: > >>>> kmod 18 Autoreconfiguring > libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `build-aux'. > libtoolize: copying file `build-aux/ltmain.sh' > libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'. > libtoolize: copying file `m4/libtool.m4' > libtoolize: copying file `m4/ltoptions.m4' > libtoolize: copying file `m4/ltsugar.m4' > libtoolize: copying file `m4/ltversion.m4' > libtoolize: copying file `m4/lt~obsolete.m4' > libkmod/docs/gtk-doc.make:270: error: HAVE_GTK_DOC does not appear in > AM_CONDITIONAL > libkmod/docs/Makefile.am:33: 'libkmod/docs/gtk-doc.make' included from > here > > And also, if the kmod-0002-add-backup-implementation-of-be32toh.patch > modifies the configure.ac file, and there is no KMOD_AUTORECONF = YES in the > kmod.mk file, why don't we clean that patch by removing the configure.ac > bit? Both problems were mentioned yesterday by Gustavo. Apparently, KMOD_AUTORECONF is broken due to something with gtk-doc. This should be fixed. At the same time, my recent new patch to kmod did not correctly add AUTORECONF (broken, but anyway) and thus does not yet take effect. If AUTORECONF cannot be fixed, then the patch should be adapted to change configure directly instead of configure.ac. I did not yet have the time to look into this second thing. Best regards, Thomas
diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk index 1f170dd..c0212bb 100644 --- a/package/kmod/kmod.mk +++ b/package/kmod/kmod.mk @@ -8,8 +8,8 @@ KMOD_VERSION = 18 KMOD_SOURCE = kmod-$(KMOD_VERSION).tar.xz KMOD_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kmod KMOD_INSTALL_STAGING = YES -KMOD_DEPENDENCIES = host-pkgconf -HOST_KMOD_DEPENDENCIES = host-pkgconf +KMOD_DEPENDENCIES = host-automake host-pkgconf +HOST_KMOD_DEPENDENCIES = host-automake host-pkgconf # license info for libkmod only, conditionally add more below KMOD_LICENSE = LGPLv2.1+