Message ID | 1412781125-11737-1-git-send-email-Vincent.Riera@imgtec.com |
---|---|
State | Superseded |
Headers | show |
Hi Vincente, On Wed, Oct 8, 2014 at 5:12 PM, Vicente Olivert Riera <Vincent.Riera@imgtec.com> wrote: > Adding the Trinity Linux System call fuzz tester. > > Fails to compile for uClibc because it tries to include 'execinfo.h' > which is only available if uClibc has been built with > UCLIBC_HAS_BACKTRACE=y (which it isn't by default). We disable this > package for uClibc by now until upstream fixes this problem. > > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> > --- > package/Config.in | 1 + > package/trinity/Config.in | 14 ++++++++++++++ > package/trinity/trinity.mk | 31 +++++++++++++++++++++++++++++++ > 3 files changed, 46 insertions(+), 0 deletions(-) > create mode 100644 package/trinity/Config.in > create mode 100644 package/trinity/trinity.mk > > diff --git a/package/Config.in b/package/Config.in > index ea89c96..3b570ee 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -89,6 +89,7 @@ endif > source "package/sysprof/Config.in" > source "package/tinymembench/Config.in" > source "package/trace-cmd/Config.in" > + source "package/trinity/Config.in" > source "package/valgrind/Config.in" > source "package/whetstone/Config.in" > endmenu > diff --git a/package/trinity/Config.in b/package/trinity/Config.in > new file mode 100644 > index 0000000..ea2c458 > --- /dev/null > +++ b/package/trinity/Config.in > @@ -0,0 +1,14 @@ > +config BR2_PACKAGE_TRINITY > + bool "trinity" > + # Fails to compile for uClibc because it tries to include 'execinfo.h' > + # which is only available if uClibc has been built with > + # UCLIBC_HAS_BACKTRACE=y (which it isn't by default). We disable this > + # package for uClibc by now until upstream fixes this problem. > + depends on !BR2_TOOLCHAIN_USES_UCLIBC > + help > + A Linux System call fuzz tester > + > + http://codemonkey.org.uk/projects/trinity/ > + > +comment "trinity is not supported for uClibc" > + depends on BR2_TOOLCHAIN_USES_UCLIBC It looks like you can now bump the version to [1] and get rid of this uclibc stuff ;-) [1] https://github.com/kernelslacker/trinity/commit/1cc389fb22ca4a7447011a7a14bb526d44197255 Regards,
Dear Samuel Martin, On 10/08/2014 08:39 PM, Samuel Martin wrote: > It looks like you can now bump the version to [1] and get rid of this > uclibc stuff ;-) > > [1] https://github.com/kernelslacker/trinity/commit/1cc389fb22ca4a7447011a7a14bb526d44197255 > > Regards, the upstream maintainer and me are working together to fix the problems with uClibc. That was the first problem and is now fixed. However, there are more problems after that one, so this package is not yet ready to be built for uClibc. Regards,
Dear all, On 10/09/2014 09:08 AM, Vicente Olivert Riera wrote: > Dear Samuel Martin, > > On 10/08/2014 08:39 PM, Samuel Martin wrote: >> It looks like you can now bump the version to [1] and get rid of this >> uclibc stuff ;-) >> >> [1] >> https://github.com/kernelslacker/trinity/commit/1cc389fb22ca4a7447011a7a14bb526d44197255 >> >> >> Regards, > > the upstream maintainer and me are working together to fix the problems > with uClibc. That was the first problem and is now fixed. However, there > are more problems after that one, so this package is not yet ready to be > built for uClibc. > > Regards, > patch v4 submitted to set the version to the latest upstream commit. http://patchwork.ozlabs.org/patch/398071/ All the uClibc issues have been fixed upstream and should be fine now. Regards,
diff --git a/package/Config.in b/package/Config.in index ea89c96..3b570ee 100644 --- a/package/Config.in +++ b/package/Config.in @@ -89,6 +89,7 @@ endif source "package/sysprof/Config.in" source "package/tinymembench/Config.in" source "package/trace-cmd/Config.in" + source "package/trinity/Config.in" source "package/valgrind/Config.in" source "package/whetstone/Config.in" endmenu diff --git a/package/trinity/Config.in b/package/trinity/Config.in new file mode 100644 index 0000000..ea2c458 --- /dev/null +++ b/package/trinity/Config.in @@ -0,0 +1,14 @@ +config BR2_PACKAGE_TRINITY + bool "trinity" + # Fails to compile for uClibc because it tries to include 'execinfo.h' + # which is only available if uClibc has been built with + # UCLIBC_HAS_BACKTRACE=y (which it isn't by default). We disable this + # package for uClibc by now until upstream fixes this problem. + depends on !BR2_TOOLCHAIN_USES_UCLIBC + help + A Linux System call fuzz tester + + http://codemonkey.org.uk/projects/trinity/ + +comment "trinity is not supported for uClibc" + depends on BR2_TOOLCHAIN_USES_UCLIBC diff --git a/package/trinity/trinity.mk b/package/trinity/trinity.mk new file mode 100644 index 0000000..1e6c54a --- /dev/null +++ b/package/trinity/trinity.mk @@ -0,0 +1,31 @@ +################################################################################ +# +# trinity +# +################################################################################ + +TRINITY_VERSION = c02034ec08d951cde3429905e64afe450cbc47db +TRINITY_SITE = $(call github,kernelslacker,trinity,$(TRINITY_VERSION)) +TRINITY_LICENSE = GPLv2 +TRINITY_LICENSE_FILES = COPYING + +define TRINITY_CONFIGURE_CMDS + (cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure.sh) +endef + +define TRINITY_BUILD_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) +endef + +define TRINITY_INSTALL_TARGET_CMDS + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR)/usr install +endef + +# Install helper scripts +define TRINITY_INSTALL_HELPER_SCRIPTS + mkdir -p $(TARGET_DIR)/usr/libexec/trinity + cp -p $(@D)/scripts/* $(TARGET_DIR)/usr/libexec/trinity/ +endef +TRINITY_POST_INSTALL_TARGET_HOOKS += TRINITY_INSTALL_HELPER_SCRIPTS + +$(eval $(generic-package))
Adding the Trinity Linux System call fuzz tester. Fails to compile for uClibc because it tries to include 'execinfo.h' which is only available if uClibc has been built with UCLIBC_HAS_BACKTRACE=y (which it isn't by default). We disable this package for uClibc by now until upstream fixes this problem. Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> --- package/Config.in | 1 + package/trinity/Config.in | 14 ++++++++++++++ package/trinity/trinity.mk | 31 +++++++++++++++++++++++++++++++ 3 files changed, 46 insertions(+), 0 deletions(-) create mode 100644 package/trinity/Config.in create mode 100644 package/trinity/trinity.mk