Message ID | 200910091611.14701.cratiu@ixiacom.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Cosmin Ratiu <cratiu@ixiacom.com> Date: Fri, 9 Oct 2009 16:11:14 +0300 > Shouldn't this be changed too then? > > Or better yet, wouldn't a change that eliminates the need of adding a new > option in two separate places be useful? Yes, it's crummy how things work now, indeed. > I see the only use for that DEVCONF enum is to dump the settings via netlink. > Wouldn't a memcpy suffice? It should be. I've applied your patch, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 13 October 2009 13:45:09 you wrote: > From: Cosmin Ratiu <cratiu@ixiacom.com> > Date: Fri, 9 Oct 2009 16:11:14 +0300 > > > Shouldn't this be changed too then? > > > > Or better yet, wouldn't a change that eliminates the need of adding a new > > option in two separate places be useful? > > Yes, it's crummy how things work now, indeed. > > > I see the only use for that DEVCONF enum is to dump the settings via > > netlink. Wouldn't a memcpy suffice? > > It should be. > I've taken a look at this and it seems the current way of doing it is really required as we need to preserve userspace ABI across different CONFIG_ settings. tavi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From f72949922a102ee9e728a2805287a9bd9a4d2e67 Mon Sep 17 00:00:00 2001 From: Cosmin Ratiu <cratiu@ixiacom.com> Date: Fri, 9 Oct 2009 15:57:09 +0300 Subject: [PATCH] [ipv6]: fix devconf after adding force_tllao option Signed-off-by: Cosmin Ratiu <cratiu@ixiacom.com> --- net/ipv6/addrconf.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 1fd0a3d..a065f40 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -3708,6 +3708,7 @@ static inline void ipv6_store_devconf(struct ipv6_devconf *cnf, #endif array[DEVCONF_DISABLE_IPV6] = cnf->disable_ipv6; array[DEVCONF_ACCEPT_DAD] = cnf->accept_dad; + array[DEVCONF_FORCE_TLLAO] = cnf->force_tllao; } static inline size_t inet6_if_nlmsg_size(void) -- 1.6.3.3