Message ID | 1408527103-22772-2-git-send-email-Yanjun.Zhu@windriver.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On 08/20/2014 05:31 AM, Zhu Yanjun wrote: > Since the transport has always been in state SCTP_UNCONFIRMED, it > therefore wasn't active before and hasn't been used before, and it > always has been, so it is unnecessary to bug the user with a > notification. > > Reported-by: Deepak Khandelwal <khandelwal.deepak.1987@gmail.com> > Suggested-by: Vlad Yasevich <vyasevich@gmail.com> > Suggested-by: Michael Tuexen <tuexen@fh-muenster.de> > Suggested-by: Daniel Borkmann <dborkman@redhat.com> > Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com> Acked-by: Vlad Yasevich <vyasevich@gmail.com> Thanks -vlad > --- > net/sctp/associola.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/sctp/associola.c b/net/sctp/associola.c > index 9de23a2..2e23f6b 100644 > --- a/net/sctp/associola.c > +++ b/net/sctp/associola.c > @@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc, > else { > dst_release(transport->dst); > transport->dst = NULL; > + ulp_notify = false; > } > > spc_state = SCTP_ADDR_UNREACHABLE; > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/20/2014 11:31 AM, Zhu Yanjun wrote: > Since the transport has always been in state SCTP_UNCONFIRMED, it > therefore wasn't active before and hasn't been used before, and it > always has been, so it is unnecessary to bug the user with a > notification. > > Reported-by: Deepak Khandelwal <khandelwal.deepak.1987@gmail.com> > Suggested-by: Vlad Yasevich <vyasevich@gmail.com> > Suggested-by: Michael Tuexen <tuexen@fh-muenster.de> > Suggested-by: Daniel Borkmann <dborkman@redhat.com> > Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com> Looks a bit better, thanks! Acked-by: Daniel Borkmann <dborkman@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Zhu Yanjun <zyjzyj2000@gmail.com> Date: Wed, 20 Aug 2014 17:31:43 +0800 > Since the transport has always been in state SCTP_UNCONFIRMED, it > therefore wasn't active before and hasn't been used before, and it > always has been, so it is unnecessary to bug the user with a > notification. > > Reported-by: Deepak Khandelwal <khandelwal.deepak.1987@gmail.com> > Suggested-by: Vlad Yasevich <vyasevich@gmail.com> > Suggested-by: Michael Tuexen <tuexen@fh-muenster.de> > Suggested-by: Daniel Borkmann <dborkman@redhat.com> > Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sctp/associola.c b/net/sctp/associola.c index 9de23a2..2e23f6b 100644 --- a/net/sctp/associola.c +++ b/net/sctp/associola.c @@ -813,6 +813,7 @@ void sctp_assoc_control_transport(struct sctp_association *asoc, else { dst_release(transport->dst); transport->dst = NULL; + ulp_notify = false; } spc_state = SCTP_ADDR_UNREACHABLE;
Since the transport has always been in state SCTP_UNCONFIRMED, it therefore wasn't active before and hasn't been used before, and it always has been, so it is unnecessary to bug the user with a notification. Reported-by: Deepak Khandelwal <khandelwal.deepak.1987@gmail.com> Suggested-by: Vlad Yasevich <vyasevich@gmail.com> Suggested-by: Michael Tuexen <tuexen@fh-muenster.de> Suggested-by: Daniel Borkmann <dborkman@redhat.com> Signed-off-by: Zhu Yanjun <Yanjun.Zhu@windriver.com> --- net/sctp/associola.c | 1 + 1 file changed, 1 insertion(+)