Message ID | 1408424370-16960-1-git-send-email-mikey@neuling.org |
---|---|
State | New, archived |
Headers | show |
On Tue, Aug 19, 2014 at 02:59:29PM +1000, Michael Neuling wrote: > This cleans up kvmppc_load/save_fp. It removes unnecessary isyncs. NAK - they are necessary on PPC970, which we (still) support. You could put them in a feature section if they are really annoying you. > It also > removes the unnecessary resetting of the MSR bits on exit of kvmppc_save_fp. ... except it doesn't. :) That got folded into e4e38121507a ("KVM: PPC: Book3S HV: Add transactional memory support"). Paul. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2014-08-19 at 15:24 +1000, Paul Mackerras wrote: > On Tue, Aug 19, 2014 at 02:59:29PM +1000, Michael Neuling wrote: > > This cleans up kvmppc_load/save_fp. It removes unnecessary isyncs. > > NAK - they are necessary on PPC970, which we (still) support. You > could put them in a feature section if they are really annoying you. I'm not fussed, but we should at least have a comment there for why we need them. > > It also > > removes the unnecessary resetting of the MSR bits on exit of kvmppc_save_fp. > > ... except it doesn't. :) That got folded into e4e38121507a ("KVM: > PPC: Book3S HV: Add transactional memory support"). Arrh, thanks. This patch was cleaning up stuff from an old local tree and couldn't see where it had been upstreamed. I missed this. Mikey -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S index f0c4db7..c4bd2d7 100644 --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S @@ -2434,7 +2434,6 @@ BEGIN_FTR_SECTION END_FTR_SECTION_IFSET(CPU_FTR_VSX) #endif mtmsrd r8 - isync addi r3,r3,VCPU_FPRS bl store_fp_state #ifdef CONFIG_ALTIVEC @@ -2470,7 +2469,6 @@ BEGIN_FTR_SECTION END_FTR_SECTION_IFSET(CPU_FTR_VSX) #endif mtmsrd r8 - isync addi r3,r4,VCPU_FPRS bl load_fp_state #ifdef CONFIG_ALTIVEC