| Message ID | 1406837317-13648-1-git-send-email-dborkman@redhat.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Daniel Borkmann <dborkman@redhat.com> Date: Thu, 31 Jul 2014 22:08:37 +0200 > In prandom we have already reseeding mechanisms that trigger > periodically from a much better entropy source than just > feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec() > [what a function name 8-)]. Therefore, just remove this. > > Signed-off-by: Daniel Borkmann <dborkman@redhat.com> > Cc: James Bottomley <JBottomley@Parallels.com> > Cc: James Smart <james.smart@emulex.com> > --- > This can also go via James, how you prefer it. James can pick this up, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2014-07-31 at 22:08 +0200, Daniel Borkmann wrote: > In prandom we have already reseeding mechanisms that trigger > periodically from a much better entropy source than just > feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec() > [what a function name 8-)]. Therefore, just remove this. > > Signed-off-by: Daniel Borkmann <dborkman@redhat.com> > Cc: James Bottomley <JBottomley@Parallels.com> > Cc: James Smart <james.smart@emulex.com> > --- > This can also go via James, how you prefer it. Could you send to linux-scsi@vger.kernel.org; Christoph Hellwig is gathering patches for SCSI via that list. Thanks, James
On 08/01/2014 06:12 AM, James Bottomley wrote: ... > Could you send to linux-scsi@vger.kernel.org; Christoph Hellwig is > gathering patches for SCSI via that list. Sure, done, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Acked-by: James Smart <james.smart@emulex.com> -- james s On 7/31/2014 4:08 PM, Daniel Borkmann wrote: > In prandom we have already reseeding mechanisms that trigger > periodically from a much better entropy source than just > feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec() > [what a function name 8-)]. Therefore, just remove this. > > Signed-off-by: Daniel Borkmann <dborkman@redhat.com> > Cc: James Bottomley <JBottomley@Parallels.com> > Cc: James Smart <james.smart@emulex.com> > --- > This can also go via James, how you prefer it. > > drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c > index 2a17e31..5072bb2 100644 > --- a/drivers/scsi/lpfc/lpfc_hbadisc.c > +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c > @@ -2146,7 +2146,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq) > uint16_t fcf_index, next_fcf_index; > struct lpfc_fcf_rec *fcf_rec = NULL; > uint16_t vlan_id; > - uint32_t seed; > bool select_new_fcf; > int rc; > > @@ -2383,9 +2382,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq) > phba->fcf.fcf_flag |= FCF_AVAILABLE; > /* Setup initial running random FCF selection count */ > phba->fcf.eligible_fcf_cnt = 1; > - /* Seeding the random number generator for random selection */ > - seed = (uint32_t)(0xFFFFFFFF & jiffies); > - prandom_seed(seed); > } > spin_unlock_irq(&phba->hbalock); > goto read_next_fcf; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 11, 2014 at 01:07:15PM -0400, James Smart wrote:
> Acked-by: James Smart <james.smart@emulex.com>
Can you jsut queue this up (and the pci fix as well) together with
anything else you have pending for 3.18?
I'd really like to move towards a model where maintainers of driver
collect everything for their area to spread work a bit better.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
yep. I'll do so. -- james s On 8/11/2014 2:18 PM, Christoph Hellwig wrote: > On Mon, Aug 11, 2014 at 01:07:15PM -0400, James Smart wrote: >> Acked-by: James Smart <james.smart@emulex.com> > Can you jsut queue this up (and the pci fix as well) together with > anything else you have pending for 3.18? > > I'd really like to move towards a model where maintainers of driver > collect everything for their area to spread work a bit better. > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 2a17e31..5072bb2 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -2146,7 +2146,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq) uint16_t fcf_index, next_fcf_index; struct lpfc_fcf_rec *fcf_rec = NULL; uint16_t vlan_id; - uint32_t seed; bool select_new_fcf; int rc; @@ -2383,9 +2382,6 @@ lpfc_mbx_cmpl_fcf_scan_read_fcf_rec(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq) phba->fcf.fcf_flag |= FCF_AVAILABLE; /* Setup initial running random FCF selection count */ phba->fcf.eligible_fcf_cnt = 1; - /* Seeding the random number generator for random selection */ - seed = (uint32_t)(0xFFFFFFFF & jiffies); - prandom_seed(seed); } spin_unlock_irq(&phba->hbalock); goto read_next_fcf;
In prandom we have already reseeding mechanisms that trigger periodically from a much better entropy source than just feeding in jiffies through lpfc_mbx_cmpl_fcf_scan_read_fcf_rec() [what a function name 8-)]. Therefore, just remove this. Signed-off-by: Daniel Borkmann <dborkman@redhat.com> Cc: James Bottomley <JBottomley@Parallels.com> Cc: James Smart <james.smart@emulex.com> --- This can also go via James, how you prefer it. drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ---- 1 file changed, 4 deletions(-)