diff mbox

nitrogen6x: include .dtb files for compatible variants

Message ID 1405012684-30163-1-git-send-email-eric.nelson@boundarydevices.com
State Accepted
Headers show

Commit Message

Eric Nelson July 10, 2014, 5:18 p.m. UTC
The Boundary Devices Nitrogen6X comes in a number of variants
with different processors, and the kernel and userspace is
compatible with the SABRE Lite (BD-SL-i.MX6), Nitrogen6_Lite,
and Nitrogen6_Max boards.

This patch adds support for these boards through the
corresponding .dtb files.

Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
 configs/nitrogen6x_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN July 10, 2014, 5:28 p.m. UTC | #1
Eric, Hadrien, All,

On 2014-07-10 10:18 -0700, Eric Nelson spake thusly:
> The Boundary Devices Nitrogen6X comes in a number of variants
> with different processors, and the kernel and userspace is
> compatible with the SABRE Lite (BD-SL-i.MX6), Nitrogen6_Lite,
> and Nitrogen6_Max boards.
> 
> This patch adds support for these boards through the
> corresponding .dtb files.
> 
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Hadrien, I think you have a few of the affected boards. Care to add this
patch to the imx series and report on it, please?

Regards,
Yann E. MORIN.

> ---
>  configs/nitrogen6x_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/nitrogen6x_defconfig b/configs/nitrogen6x_defconfig
> index da2a7e8..04db23a 100644
> --- a/configs/nitrogen6x_defconfig
> +++ b/configs/nitrogen6x_defconfig
> @@ -26,4 +26,4 @@ BR2_LINUX_KERNEL_DEFCONFIG="nitrogen6x"
>  BR2_LINUX_KERNEL_INSTALL_TARGET=y
>  BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x10008000"
>  BR2_LINUX_KERNEL_DTS_SUPPORT=y
> -BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-nitrogen6x"
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6dl-nit6xlite imx6dl-nitrogen6_max imx6dl-nitrogen6x imx6q-nitrogen6_max imx6q-nitrogen6x imx6q-sabrelite"
> -- 
> 1.9.1
>
Gary Bisson July 10, 2014, 6:22 p.m. UTC | #2
Eric, All,

What about the bootloader configuration? I know the same bootloader will
work the same for sabrelite and nitrogen6q. However for the max and dl
versions I guess need another config as the DCD table will be different. Do
we want to create other defconfigs?

Regards,
Gary


On Thu, Jul 10, 2014 at 10:28 AM, Yann E. MORIN <yann.morin.1998@free.fr>
wrote:

> Eric, Hadrien, All,
>
> On 2014-07-10 10:18 -0700, Eric Nelson spake thusly:
> > The Boundary Devices Nitrogen6X comes in a number of variants
> > with different processors, and the kernel and userspace is
> > compatible with the SABRE Lite (BD-SL-i.MX6), Nitrogen6_Lite,
> > and Nitrogen6_Max boards.
> >
> > This patch adds support for these boards through the
> > corresponding .dtb files.
> >
> > Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Hadrien, I think you have a few of the affected boards. Care to add this
> patch to the imx series and report on it, please?
>
> Regards,
> Yann E. MORIN.
>
> > ---
> >  configs/nitrogen6x_defconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configs/nitrogen6x_defconfig b/configs/nitrogen6x_defconfig
> > index da2a7e8..04db23a 100644
> > --- a/configs/nitrogen6x_defconfig
> > +++ b/configs/nitrogen6x_defconfig
> > @@ -26,4 +26,4 @@ BR2_LINUX_KERNEL_DEFCONFIG="nitrogen6x"
> >  BR2_LINUX_KERNEL_INSTALL_TARGET=y
> >  BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x10008000"
> >  BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > -BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-nitrogen6x"
> > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6dl-nit6xlite imx6dl-nitrogen6_max
> imx6dl-nitrogen6x imx6q-nitrogen6_max imx6q-nitrogen6x imx6q-sabrelite"
> > --
> > 1.9.1
> >
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>       |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There
> is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
> conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>
Eric Nelson July 10, 2014, 6:35 p.m. UTC | #3
Thanks for the ping, Gary.

On 07/10/2014 11:22 AM, Gary Bisson wrote:
> Eric, All,
> 
> What about the bootloader configuration? I know the same bootloader will
> work the same for sabrelite and nitrogen6q. However for the max and dl
> versions I guess need another config as the DCD table will be different.
> Do we want to create other defconfigs?
> 

As our boards don't require U-Boot to be built in order to
craft a filesystem (U-Boot runs from SPI NOR), we could simply
remove the build target.

At the very least, we should probably find a way to rename the U-Boot
binary (u-boot.imx) to make it clear that the one built is for
the Quad-Core/1GiB variant.

I'll try to craft a way of doing this.

Regards,


Eric
Arnout Vandecappelle July 11, 2014, 6:10 a.m. UTC | #4
On 10/07/14 20:35, Eric Nelson wrote:
> Thanks for the ping, Gary.
> 
> On 07/10/2014 11:22 AM, Gary Bisson wrote:
>> Eric, All,
>>
>> What about the bootloader configuration? I know the same bootloader will
>> work the same for sabrelite and nitrogen6q. However for the max and dl
>> versions I guess need another config as the DCD table will be different.
>> Do we want to create other defconfigs?
>>
> 
> As our boards don't require U-Boot to be built in order to
> craft a filesystem (U-Boot runs from SPI NOR), we could simply
> remove the build target.
> 
> At the very least, we should probably find a way to rename the U-Boot
> binary (u-boot.imx) to make it clear that the one built is for
> the Quad-Core/1GiB variant.

 I think it's best to still build the bootloader for one variant, and mention in
the readme.txt the different variants and how to build their bootloaders.

 That readme anyway needs to be extended a bit since it doesn't mention how to
install the kernel or the bootloader.

 Regards,
 Arnout
Thomas Petazzoni July 15, 2014, 9:16 p.m. UTC | #5
Dear Eric Nelson,

On Thu, 10 Jul 2014 10:18:04 -0700, Eric Nelson wrote:
> The Boundary Devices Nitrogen6X comes in a number of variants
> with different processors, and the kernel and userspace is
> compatible with the SABRE Lite (BD-SL-i.MX6), Nitrogen6_Lite,
> and Nitrogen6_Max boards.
> 
> This patch adds support for these boards through the
> corresponding .dtb files.
> 
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>  configs/nitrogen6x_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks. The issues raised in the discussion (adding the build
of a bootloader) can be handled in followup patches. Contributions
welcome.

Thanks!

Thomas
Eric Nelson July 15, 2014, 9:29 p.m. UTC | #6
Hi Thomas,

On 07/15/2014 02:16 PM, Thomas Petazzoni wrote:
> Dear Eric Nelson,
> 
> <snip>
>
>
> The issues raised in the discussion (adding the build
> of a bootloader) can be handled in followup patches. Contributions
> welcome.
> 

Will do.
diff mbox

Patch

diff --git a/configs/nitrogen6x_defconfig b/configs/nitrogen6x_defconfig
index da2a7e8..04db23a 100644
--- a/configs/nitrogen6x_defconfig
+++ b/configs/nitrogen6x_defconfig
@@ -26,4 +26,4 @@  BR2_LINUX_KERNEL_DEFCONFIG="nitrogen6x"
 BR2_LINUX_KERNEL_INSTALL_TARGET=y
 BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x10008000"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-nitrogen6x"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6dl-nit6xlite imx6dl-nitrogen6_max imx6dl-nitrogen6x imx6q-nitrogen6_max imx6q-nitrogen6x imx6q-sabrelite"