diff mbox

hyperv: fix apparent cut-n-paste error in send path teardown

Message ID 20140616205902.GA7331@redhat.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Dave Jones June 16, 2014, 8:59 p.m. UTC
c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added
some teardown code that looks like it was copied from the recieve path
above, but missed a variable name replacement.

Signed-off-by: Dave Jones <davej@redhat.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller June 17, 2014, 4:36 a.m. UTC | #1
From: Dave Jones <davej@redhat.com>
Date: Mon, 16 Jun 2014 16:59:02 -0400

> c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added
> some teardown code that looks like it was copied from the recieve path
> above, but missed a variable name replacement.
> 
> Signed-off-by: Dave Jones <davej@redhat.com>

Good catch, applied, thanks Dave.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
KY Srinivasan June 17, 2014, 10:13 a.m. UTC | #2
> -----Original Message-----
> From: Dave Jones [mailto:davej@redhat.com]
> Sent: Monday, June 16, 2014 1:59 PM
> To: netdev@vger.kernel.org
> Cc: KY Srinivasan
> Subject: hyperv: fix apparent cut-n-paste error in send path teardown
> 
> c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added
> some teardown code that looks like it was copied from the recieve path
> above, but missed a variable name replacement.

Thank you.

K. Y
> 
> Signed-off-by: Dave Jones <davej@redhat.com>
> 
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index
> c041f63a6d30..4ed38eaecea8 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -189,7 +189,7 @@ static int netvsc_destroy_buf(struct netvsc_device
> *net_device)
>  				   "unable to teardown send buffer's
> gpadl\n");
>  			return ret;
>  		}
> -		net_device->recv_buf_gpadl_handle = 0;
> +		net_device->send_buf_gpadl_handle = 0;
>  	}
>  	if (net_device->send_buf) {
>  		/* Free up the receive buffer */
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index c041f63a6d30..4ed38eaecea8 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -189,7 +189,7 @@  static int netvsc_destroy_buf(struct netvsc_device *net_device)
 				   "unable to teardown send buffer's gpadl\n");
 			return ret;
 		}
-		net_device->recv_buf_gpadl_handle = 0;
+		net_device->send_buf_gpadl_handle = 0;
 	}
 	if (net_device->send_buf) {
 		/* Free up the receive buffer */