diff mbox

[request,for,stable,inclusion] ipv6: reallocate addrconf router for ipv6 address when lo device up

Message ID 1402884279-11896-1-git-send-email-chenweilong@huawei.com
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

chenweilong June 16, 2014, 2:04 a.m. UTC
From: Gao feng <gaofeng@cn.fujitsu.com>

commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.

/* CHANGELOG */

CC: Sabrina Dubroca <sd@queasysnail.net>
CC: Hannes Frederic Sowa <hannes@stressinduktion.org>
Reported-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
[weilong: s/ip6_rt_put/dst_release]
Signed-off-by: Chen Weilong <chenweilong@huawei.com>
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
 net/ipv6/addrconf.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

Comments

David Miller June 16, 2014, 2:29 a.m. UTC | #1
From: Chen Weilong <chenweilong@huawei.com>
Date: Mon, 16 Jun 2014 10:04:39 +0800

> From: Gao feng <gaofeng@cn.fujitsu.com>
> 
> commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.
> 
> /* CHANGELOG */
> 

No, this is not how you ask for networking changes to be submitted to
-stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
chenweilong June 16, 2014, 3:14 a.m. UTC | #2
Oh..sorry,

I must missed something important!
What's the right way?

This patch solves the bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951
It's very worthy to be applied to stable 3.4.x kernels.
As this patch can't be applied directly, I just modify
it in my last mail,

Thanks,

Weilong

On 2014/6/16 10:29, David Miller wrote:
> From: Chen Weilong <chenweilong@huawei.com>
> Date: Mon, 16 Jun 2014 10:04:39 +0800
> 
>> From: Gao feng <gaofeng@cn.fujitsu.com>
>>
>> commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.
>>
>> /* CHANGELOG */
>>
> 
> No, this is not how you ask for networking changes to be submitted to
> -stable.
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Cong Wang June 16, 2014, 5:19 p.m. UTC | #3
On Sun, Jun 15, 2014 at 8:14 PM, chenweilong <chenweilong@huawei.com> wrote:
> Oh..sorry,
>
> I must missed something important!

Yes, you miss the FAQ:
https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt

> What's the right way?
>

Q: How can I tell what patches are queued up for backporting to the
   various stable releases?

A: Normally Greg Kroah-Hartman collects stable commits himself, but
   for networking, Dave collects up patches he deems critical for the
   networking subsystem, and then hands them off to Greg.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
chenweilong June 17, 2014, 3:27 a.m. UTC | #4
Thanks!

On 2014/6/17 1:19, Cong Wang wrote:
> On Sun, Jun 15, 2014 at 8:14 PM, chenweilong <chenweilong@huawei.com> wrote:
>> Oh..sorry,
>>
>> I must missed something important!
> 
> Yes, you miss the FAQ:
> https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt
> 
>> What's the right way?
>>
> 
> Q: How can I tell what patches are queued up for backporting to the
>    various stable releases?
> 
> A: Normally Greg Kroah-Hartman collects stable commits himself, but
>    for networking, Dave collects up patches he deems critical for the
>    networking subsystem, and then hands them off to Greg.
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index abfa007..25399bf 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2435,8 +2435,18 @@  static void init_loopback(struct net_device *dev)
 			if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
 				continue;
 
-			if (sp_ifa->rt)
-				continue;
+			if (sp_ifa->rt) {
+				/* This dst has been added to garbage list when
+				 * lo device down, release this obsolete dst and
+				 * reallocate a new router for ifa.
+				 */
+				if (sp_ifa->rt->dst.obsolete > 0) {
+					dst_release(sp_ifa->rt);
+					sp_ifa->rt = NULL;
+				} else {
+					continue;
+				}
+			}
 
 			sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);