diff mbox

add LTE defines to GSMTAP v2

Message ID 1402419899-24862-1-git-send-email-Max.Suraev@fairwaves.co
State Accepted
Headers show

Commit Message

Max June 10, 2014, 5:04 p.m. UTC 
---
 include/osmocom/core/gsmtap.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Max June 10, 2014, 5:11 p.m. UTC | #1 
Thanks for your comments: incorporated @ttsou suggestion on SCH, fixed tab-vs-space.
As for whitespace change in the beginning - I think it's necessary to match usage of
====== header throughout the rest of the file.
Sylvain Munaut June 10, 2014, 5:56 p.m. UTC | #2 
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>


I'll give it a couple of days to make sure everybody interested has a
chance to view it, but if there are no other comments / suggestions in
the mean time, I'll push that to master.
Sylvain Munaut June 15, 2014, 4:58 p.m. UTC | #3 
Applied.

BTW, you might want to include a signed-off-by line next time.

Cheers,

   Sylvain
Max June 15, 2014, 9:35 p.m. UTC | #4 
Thanks.
Is there some git option for that or it's just plain text in a long comment?

15.06.2014 18:58, Sylvain Munaut пишет:
> Applied.
> 
> BTW, you might want to include a signed-off-by line next time.
> 
> Cheers,
> 
>    Sylvain
>
Thomas Tsou June 15, 2014, 10:04 p.m. UTC | #5 
On Sun, Jun 15, 2014 at 5:35 PM, ☎ <Max.Suraev@fairwaves.co> wrote:
> Is there some git option for that or it's just plain text in a long comment?

git commit --signoff

 -TT
Alexander Huemer June 15, 2014, 10:08 p.m. UTC | #6 
On Sun, Jun 15, 2014 at 11:35:16PM +0200, ☎ wrote:
> 15.06.2014 18:58, Sylvain Munaut пишет:
> > BTW, you might want to include a signed-off-by line next time.
> 
> Is there some git option for that or it's just plain text in a long 
> comment?

That's an option to 'git commit', it's '-s, --signoff', documented in 
the man page.

Kind regards,
-Alex
Max June 16, 2014, 9:19 a.m. UTC | #7 
Thanks for clarification guys. One more thing - was I supposed to put me or Sylvain
in there?
Sylvain Munaut June 16, 2014, 10:02 a.m. UTC | #8 
> Thanks for clarification guys. One more thing - was I supposed to put me or Sylvain
> in there?

Yourself.

The Signed-off-by chain is essentially taking responsibility for the patch.

When taking a patch off the list, I'll add my own line to it to
basically say I looked over the patch, tested it and that to the best
of my knowledge the patch complies with the license.

Cheers,

   Sylvain
diff mbox

Patch

diff --git a/include/osmocom/core/gsmtap.h b/include/osmocom/core/gsmtap.h
index c1c53d0..5fac711 100644
--- a/include/osmocom/core/gsmtap.h
+++ b/include/osmocom/core/gsmtap.h
@@ -43,7 +43,7 @@ 
 #define GSMTAP_TYPE_GMR1_UM	0x0a	/* GMR-1 L2 packets */
 #define GSMTAP_TYPE_UMTS_RLC_MAC	0x0b
 #define GSMTAP_TYPE_UMTS_RRC	0x0c
-
+#define GSMTAP_TYPE_LTE_RRC	0x0d /* LTE interface */
 
 /* ====== DO NOT MAKE UNAPPROVED MODIFICATIONS HERE ===== */
 
@@ -135,6 +135,15 @@ 
 #define GSMTAP_UMTS_CH_CCCH	0x02
 #define GSMTAP_UMTS_CH_DCCH	0x03
 
+/* sub-types for TYPE_LTE_RRC */
+#define GSMTAP_LTE_CH_BCCH	0x01
+#define GSMTAP_LTE_CH_CCCH	0x02
+#define GSMTAP_LTE_CH_DCCH	0x03
+#define GSMTAP_LTE_CH_MCCH	0x04
+#define GSMTAP_LTE_CH_PCCH	0x05
+#define GSMTAP_LTE_CH_DTCH	0x06
+#define GSMTAP_LTE_CH_MTCH	0x07
+
 /* flags for the ARFCN */
 #define GSMTAP_ARFCN_F_PCS	0x8000
 #define GSMTAP_ARFCN_F_UPLINK	0x4000