[v2,1/6] pch_gbe: print invalid MAC address during probe

From: Daniel Krueger <daniel.krueger@systec-electronic.com>

It is also neat to show the actual offending MAC address instead of just
rejecting it

Signed-off-by: Daniel Krueger <daniel.krueger@systec-electronic.com>
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---

Changes in v2:
* Use just a single line

 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

2014-06-05 1:53 GMT-07:00 Alexander Stein
<alexander.stein@systec-electronic.com>:
> From: Daniel Krueger <daniel.krueger@systec-electronic.com>
>
> It is also neat to show the actual offending MAC address instead of just
> rejecting it

Most drivers do use a random Ethernet MAC address instead of bailing
out, which might be a more sensible option.

>
> Signed-off-by: Daniel Krueger <daniel.krueger@systec-electronic.com>
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>
> Changes in v2:
> * Use just a single line
>
>  drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> index 73e6683..cf3101c 100644
> --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> @@ -2672,8 +2672,7 @@ static int pch_gbe_probe(struct pci_dev *pdev,
>                  * prevent the interface from being brought up until a valid MAC
>                  * is set.
>                  */
> -               dev_err(&pdev->dev, "Invalid MAC address, "
> -                                   "interface disabled.\n");
> +               dev_err(&pdev->dev, "Invalid MAC address %pM - interface disabled.\n", adapter->hw.mac.addr);
>         }
>         setup_timer(&adapter->watchdog_timer, pch_gbe_watchdog,
>                     (unsigned long)adapter);
> --
> 1.8.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

From: Alexander Stein <alexander.stein@systec-electronic.com>
Date: Thu,  5 Jun 2014 10:53:02 +0200

> From: Daniel Krueger <daniel.krueger@systec-electronic.com>
> 
> It is also neat to show the actual offending MAC address instead of just
> rejecting it
> 
> Signed-off-by: Daniel Krueger <daniel.krueger@systec-electronic.com>
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> 
> Changes in v2:
> * Use just a single line

I agree with other's feedback in that this code is not legitimate.

It should generate a random MAC address via the standard interfaces we
have for doing so, rather than failing to bring up the interface.

Interface bringup failure should be the absolute last resort, and we
should recover and still bring the interface up whenever we can.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html