| Message ID | 1400824114-27148-1-git-send-email-shawn.guo@freescale.com |
|---|---|
| State | Rejected |
| Headers | show |
Hi Shawn, On 05/23/2014 01:48 PM, Shawn Guo wrote: > The .config() hook of imx_pwm_data_v2 calls clk_get_rate() which might > sleep, so we need to set can_sleep flag on it. > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > --- > drivers/pwm/pwm-imx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c > index d797c7b84c3f..ab3809fb36a7 100644 > --- a/drivers/pwm/pwm-imx.c > +++ b/drivers/pwm/pwm-imx.c > @@ -272,6 +272,9 @@ static int imx_pwm_probe(struct platform_device *pdev) > imx->config = data->config; > imx->set_enable = data->set_enable; > > + if (data == &imx_pwm_data_v2) > + imx->chip.can_sleep = true; > + > ret = pwmchip_add(&imx->chip); > if (ret < 0) > return ret; > clk_prepare_enable()/clk_disable_unprepare() called in imx_pwm_config() may sleep. So, the can_sleep flag should be true for both i.MX PWM v1 and v2, right?
On Fri, May 23, 2014 at 02:40:04PM +0800, Liu Ying wrote: > Hi Shawn, > > On 05/23/2014 01:48 PM, Shawn Guo wrote: > > The .config() hook of imx_pwm_data_v2 calls clk_get_rate() which might > > sleep, so we need to set can_sleep flag on it. > > > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > > --- > > drivers/pwm/pwm-imx.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c > > index d797c7b84c3f..ab3809fb36a7 100644 > > --- a/drivers/pwm/pwm-imx.c > > +++ b/drivers/pwm/pwm-imx.c > > @@ -272,6 +272,9 @@ static int imx_pwm_probe(struct platform_device *pdev) > > imx->config = data->config; > > imx->set_enable = data->set_enable; > > > > + if (data == &imx_pwm_data_v2) > > + imx->chip.can_sleep = true; > > + > > ret = pwmchip_add(&imx->chip); > > if (ret < 0) > > return ret; > > > > clk_prepare_enable()/clk_disable_unprepare() called in imx_pwm_config() may sleep. > > So, the can_sleep flag should be true for both i.MX PWM v1 and v2, right? Yes, you're right. I missed that. Thanks for pointing it out. Will send v2 shortly. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c index d797c7b84c3f..ab3809fb36a7 100644 --- a/drivers/pwm/pwm-imx.c +++ b/drivers/pwm/pwm-imx.c @@ -272,6 +272,9 @@ static int imx_pwm_probe(struct platform_device *pdev) imx->config = data->config; imx->set_enable = data->set_enable; + if (data == &imx_pwm_data_v2) + imx->chip.can_sleep = true; + ret = pwmchip_add(&imx->chip); if (ret < 0) return ret;
The .config() hook of imx_pwm_data_v2 calls clk_get_rate() which might sleep, so we need to set can_sleep flag on it. Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- drivers/pwm/pwm-imx.c | 3 +++ 1 file changed, 3 insertions(+)