File recipe

---
 recipes/file/file.inc         | 14 ++++++++++++++
 recipes/file/file_5.18.oe     |  2 ++
 recipes/file/file_5.18.oe.sig |  1 +
 3 files changed, 17 insertions(+)
 create mode 100644 recipes/file/file.inc
 create mode 100644 recipes/file/file_5.18.oe
 create mode 100644 recipes/file/file_5.18.oe.sig

Mikael Jansson <mikael.jansson@tlabwest.se> writes:

Hi Michael

I changed the commit message to "file: New recipe".  Using similar
wording when adding new recipes makes it much easier to generate a list
of new recipes for a release.

> ---
>  recipes/file/file.inc         | 14 ++++++++++++++
>  recipes/file/file_5.18.oe     |  2 ++
>  recipes/file/file_5.18.oe.sig |  1 +
>  3 files changed, 17 insertions(+)
>  create mode 100644 recipes/file/file.inc
>  create mode 100644 recipes/file/file_5.18.oe
>  create mode 100644 recipes/file/file_5.18.oe.sig
>
> diff --git a/recipes/file/file.inc b/recipes/file/file.inc
> new file mode 100644
> index 0000000..c27feee
> --- /dev/null
> +++ b/recipes/file/file.inc
> @@ -0,0 +1,14 @@
> +SUMMARY = "File is a utility that classifies arbitrary files of any type
> mainly by their contents."

Tak care.  Your patch were line wrapped, so I had to unmangle it to
merge it.  Luckily, it was just this one line :)

> +DESCRIPTION = ""
> +HOMEPAGE = "http://freecode.com/projects/file"
> +LICENSE = "BSD"
> +
> +RECIPE_TYPES = "native machine"
> +DEPENDS:>machine += " native:file"
> +
> +SRC_URI = "ftp://ftp.astron.com/pub/file/file-${PV}.tar.gz"
> +
> +FILES_${PN} += "${datadir}/misc/magic.mgc"
> +
> +inherit autotools
> +

Try to avoid trailing white space (including trailing blank lines).

> diff --git a/recipes/file/file_5.18.oe b/recipes/file/file_5.18.oe
> new file mode 100644
> index 0000000..1b36f63
> --- /dev/null
> +++ b/recipes/file/file_5.18.oe
> @@ -0,0 +1,2 @@
> +require file.inc
> +

Ditto.

> diff --git a/recipes/file/file_5.18.oe.sig b/recipes/file/file_5.18.oe.sig
> new file mode 100644
> index 0000000..1798134
> --- /dev/null
> +++ b/recipes/file/file_5.18.oe.sig
> @@ -0,0 +1 @@
> +8753e72097f2cc935608e3b1c57c4c4e31bd8d21  file-5.18.tar.gz
> -- 
> 1.8.5.3

Merged to master, thanks.

/Esben

>
> I changed the commit message to "file: New recipe".  Using similar
> wording when adding new recipes makes it much easier to generate a list
> of new recipes for a release.
>
> Noted for possible future patches.


> > ---
> >  recipes/file/file.inc         | 14 ++++++++++++++
> >  recipes/file/file_5.18.oe     |  2 ++
> >  recipes/file/file_5.18.oe.sig |  1 +
> >  3 files changed, 17 insertions(+)
> >  create mode 100644 recipes/file/file.inc
> >  create mode 100644 recipes/file/file_5.18.oe
> >  create mode 100644 recipes/file/file_5.18.oe.sig
> >
> > diff --git a/recipes/file/file.inc b/recipes/file/file.inc
> > new file mode 100644
> > index 0000000..c27feee
> > --- /dev/null
> > +++ b/recipes/file/file.inc
> > @@ -0,0 +1,14 @@
> > +SUMMARY = "File is a utility that classifies arbitrary files of any type
> > mainly by their contents."
>
> Tak care.  Your patch were line wrapped, so I had to unmangle it to
> merge it.  Luckily, it was just this one line :)
>
>
Patch file looks good on my end. I blame gmail. Should I send the patches
as attachments instead?


> > +DESCRIPTION = ""
> > +HOMEPAGE = "http://freecode.com/projects/file"
> > +LICENSE = "BSD"
> > +
> > +RECIPE_TYPES = "native machine"
> > +DEPENDS:>machine += " native:file"
> > +
> > +SRC_URI = "ftp://ftp.astron.com/pub/file/file-${PV}.tar.gz"
> > +
> > +FILES_${PN} += "${datadir}/misc/magic.mgc"
> > +
> > +inherit autotools
> > +
>
> Try to avoid trailing white space (including trailing blank lines).


Noted!

- Mikael

Mikael Jansson <mikael.jansson@tlabwest.se> writes:

>     Tak care.  Your patch were line wrapped, so I had to unmangle it to
>     merge it.  Luckily, it was just this one line :)
>
> Patch file looks good on my end. I blame gmail.

I remember having same problems with gmail...

> Should I send the patches as attachments instead?

No thanks.  It makes code review very difficult.

But if you could push
your commits to a git repo (fx. on gitorious.org, github, bitbucket, or
wherever), and send your patches as pull-requests, ie. with reference to
how I can pull them with git, I can just cherry-pick your commits
if/when gmail has mangled the patches.

/Esben