Message ID | 20090824043831.GA2473@orion |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Alexander Beregalov <a.beregalov@gmail.com> Date: Mon, 24 Aug 2009 08:38:31 +0400 > Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops > > This patch fixes broken pxaficp-ir. The problem was in incorrect > net_device_ops being specified which prevented the driver from > operating. The symptoms were: > - failing ifconfig for IrLAN, resulting in > SIOCSIFFLAGS: Cannot assign requested address > - irattach working for IrCOMM, but the port stayed disabled > > Moreover this patch corrects missing sysfs device link. > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dne Po 24. srpna 2009 07:57:43 David Miller napsal(a): > From: Alexander Beregalov <a.beregalov@gmail.com> > Date: Mon, 24 Aug 2009 08:38:31 +0400 > > > Subject: [PATCH] pxaficp-ir - remove incorrect net_device_ops > > > > This patch fixes broken pxaficp-ir. The problem was in incorrect > > net_device_ops being specified which prevented the driver from > > operating. The symptoms were: > > - failing ifconfig for IrLAN, resulting in > > SIOCSIFFLAGS: Cannot assign requested address > > - irattach working for IrCOMM, but the port stayed disabled > > > > Moreover this patch corrects missing sysfs device link. > > > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com> > > Applied, thanks. Thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/irda/pxaficp_ir.c b/drivers/net/irda/pxaficp_ir.c index 4edbdbe..f5b7d83 100644 --- a/drivers/net/irda/pxaficp_ir.c +++ b/drivers/net/irda/pxaficp_ir.c @@ -820,9 +820,6 @@ static const struct net_device_ops pxa_irda_netdev_ops = { .ndo_stop = pxa_irda_stop, .ndo_start_xmit = pxa_irda_hard_xmit, .ndo_do_ioctl = pxa_irda_ioctl, - .ndo_change_mtu = eth_change_mtu, - .ndo_validate_addr = eth_validate_addr, - .ndo_set_mac_address = eth_mac_addr, }; static int pxa_irda_probe(struct platform_device *pdev) @@ -847,6 +844,7 @@ static int pxa_irda_probe(struct platform_device *pdev) if (!dev) goto err_mem_3; + SET_NETDEV_DEV(dev, &pdev->dev); si = netdev_priv(dev); si->dev = &pdev->dev; si->pdata = pdev->dev.platform_data;