Message ID | alpine.DEB.1.10.1405160245300.12061@tp.orcam.me.uk |
---|---|
State | Not Applicable |
Headers | show |
On Fri, 16 May 2014, Maciej W. Rozycki wrote: > 2014-05-16 Maciej W. Rozycki <macro@codesourcery.com> > > PR libgcc/60166 > * sysdeps/arm/soft-fp/sfp-machine.h (_FP_NANFRAC_S, _FP_NANFRAC_D) > (_FP_NANSIGN_Q): Set the quiet bit. OK for glibc.
On Fri, 16 May 2014, Joseph S. Myers wrote: > > 2014-05-16 Maciej W. Rozycki <macro@codesourcery.com> > > > > PR libgcc/60166 > > * sysdeps/arm/soft-fp/sfp-machine.h (_FP_NANFRAC_S, _FP_NANFRAC_D) > > (_FP_NANSIGN_Q): Set the quiet bit. > > OK for glibc. Joseph, thanks for your review, this is now in. Richard, you wrote yesterday that pushing changes to 4.8 would require explicit approval from release managers, however it is not clear to me who they are for that branch. This fix corrects a regression introduced after 4.8.2. Can you approve it? If not, then who can? Maciej
On May 17, 2014 12:22:23 AM CEST, "Maciej W. Rozycki" <macro@codesourcery.com> wrote: >On Fri, 16 May 2014, Joseph S. Myers wrote: > >> > 2014-05-16 Maciej W. Rozycki <macro@codesourcery.com> >> > >> > PR libgcc/60166 >> > * sysdeps/arm/soft-fp/sfp-machine.h (_FP_NANFRAC_S, _FP_NANFRAC_D) >> > (_FP_NANSIGN_Q): Set the quiet bit. >> >> OK for glibc. > > Joseph, thanks for your review, this is now in. > >Richard, you wrote yesterday that pushing changes to 4.8 would require >explicit approval from release managers, however it is not clear to me >who >they are for that branch. This fix corrects a regression introduced >after >4.8.2. Can you approve it? If not, then who can? If it's not broken in 4.8.2 but broken on the branch head then it's OK for the branch. Thanks, Richard. > Maciej
Index: glibc-fsf-trunk-quilt/sysdeps/arm/soft-fp/sfp-machine.h =================================================================== --- glibc-fsf-trunk-quilt.orig/sysdeps/arm/soft-fp/sfp-machine.h 2014-05-16 03:25:52.000000000 +0100 +++ glibc-fsf-trunk-quilt/sysdeps/arm/soft-fp/sfp-machine.h 2014-05-16 03:31:34.451805339 +0100 @@ -21,9 +21,9 @@ #define _FP_DIV_MEAT_D(R,X,Y) _FP_DIV_MEAT_2_udiv(D,R,X,Y) #define _FP_DIV_MEAT_Q(R,X,Y) _FP_DIV_MEAT_4_udiv(Q,R,X,Y) -#define _FP_NANFRAC_S 0 -#define _FP_NANFRAC_D 0, 0 -#define _FP_NANFRAC_Q 0, 0, 0, 0 +#define _FP_NANFRAC_S _FP_QNANBIT_S +#define _FP_NANFRAC_D _FP_QNANBIT_D, 0 +#define _FP_NANFRAC_Q _FP_QNANBIT_Q, 0, 0, 0 #define _FP_NANSIGN_S 0 #define _FP_NANSIGN_D 0 #define _FP_NANSIGN_Q 0