Message ID | 20140516112904.7072da0f@endymion.delvare |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Fri, 2014-05-16 at 11:29 +0200, Jean Delvare wrote: > The pch_gbe driver is for a companion chip to the Intel Atom E600 > series processors. These are 32-bit x86 processors so the driver is > only needed on X86_32. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Jiri Slaby <jslaby@suse.cz> > Cc: David S. Miller <davem@davemloft.net> > --- > drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-3.15-rc5.orig/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-03-31 05:40:15.000000000 +0200 > +++ linux-3.15-rc5/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-05-16 11:20:28.453261606 +0200 > @@ -4,7 +4,7 @@ > > config PCH_GBE > tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE" > - depends on PCI && (X86 || COMPILE_TEST) > + depends on PCI && (X86_32 || COMPILE_TEST) > select MII > select PTP_1588_CLOCK_PCH > ---help--- > > Although its always nice to be able to compile it with x86_64 host, to make sure we do not add regressions when we change something in a core networking part. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Fri, 16 May 2014 06:16:01 -0700 > On Fri, 2014-05-16 at 11:29 +0200, Jean Delvare wrote: >> The pch_gbe driver is for a companion chip to the Intel Atom E600 >> series processors. These are 32-bit x86 processors so the driver is >> only needed on X86_32. >> >> Signed-off-by: Jean Delvare <jdelvare@suse.de> >> Cc: Jiri Slaby <jslaby@suse.cz> >> Cc: David S. Miller <davem@davemloft.net> >> --- >> drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-3.15-rc5.orig/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-03-31 05:40:15.000000000 +0200 >> +++ linux-3.15-rc5/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-05-16 11:20:28.453261606 +0200 >> @@ -4,7 +4,7 @@ >> >> config PCH_GBE >> tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE" >> - depends on PCI && (X86 || COMPILE_TEST) >> + depends on PCI && (X86_32 || COMPILE_TEST) >> select MII >> select PTP_1588_CLOCK_PCH >> ---help--- >> >> > > Although its always nice to be able to compile it with x86_64 host, > to make sure we do not add regressions when we change something in a > core networking part. That's what COMPILE_TEST is supposed to be for and it's still there :) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2014-05-16 at 13:05 -0400, David Miller wrote:
> That's what COMPILE_TEST is supposed to be for and it's still there :)
Ah nice, I missed this feature, thanks ;)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jean Delvare <jdelvare@suse.de> Date: Fri, 16 May 2014 11:29:04 +0200 > The pch_gbe driver is for a companion chip to the Intel Atom E600 > series processors. These are 32-bit x86 processors so the driver is > only needed on X86_32. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-3.15-rc5.orig/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-03-31 05:40:15.000000000 +0200 +++ linux-3.15-rc5/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig 2014-05-16 11:20:28.453261606 +0200 @@ -4,7 +4,7 @@ config PCH_GBE tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE" - depends on PCI && (X86 || COMPILE_TEST) + depends on PCI && (X86_32 || COMPILE_TEST) select MII select PTP_1588_CLOCK_PCH ---help---
The pch_gbe driver is for a companion chip to the Intel Atom E600 series processors. These are 32-bit x86 processors so the driver is only needed on X86_32. Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Jiri Slaby <jslaby@suse.cz> Cc: David S. Miller <davem@davemloft.net> --- drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)