| Message ID | 53718A36.1040907@huawei.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> Signed-off-by: Wang Weidong <wangweidong1@huawei.com> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk> > --- > net/dccp/sysctl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c > index 607ab71..53731e4 100644 > --- a/net/dccp/sysctl.c > +++ b/net/dccp/sysctl.c > @@ -20,6 +20,7 @@ > > /* Boundary values */ > static int zero = 0, > + one = 1, > u8_max = 0xFF; > static unsigned long seqw_min = DCCPF_SEQ_WMIN, > seqw_max = 0xFFFFFFFF; /* maximum on 32 bit */ > @@ -58,7 +59,7 @@ static struct ctl_table dccp_default_table[] = { > .maxlen = sizeof(sysctl_dccp_request_retries), > .mode = 0644, > .proc_handler = proc_dointvec_minmax, > - .extra1 = &zero, > + .extra1 = &one, > .extra2 = &u8_max, > }, > { -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Wang Weidong <wangweidong1@huawei.com> Date: Tue, 13 May 2014 10:57:58 +0800 > In Documentation/networking/dccp.txt points that request_retries > should be greater than 0. So make the extra1 to be &one instead > of &zero. > > Signed-off-by: Wang Weidong <wangweidong1@huawei.com> Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/dccp/sysctl.c b/net/dccp/sysctl.c index 607ab71..53731e4 100644 --- a/net/dccp/sysctl.c +++ b/net/dccp/sysctl.c @@ -20,6 +20,7 @@ /* Boundary values */ static int zero = 0, + one = 1, u8_max = 0xFF; static unsigned long seqw_min = DCCPF_SEQ_WMIN, seqw_max = 0xFFFFFFFF; /* maximum on 32 bit */ @@ -58,7 +59,7 @@ static struct ctl_table dccp_default_table[] = { .maxlen = sizeof(sysctl_dccp_request_retries), .mode = 0644, .proc_handler = proc_dointvec_minmax, - .extra1 = &zero, + .extra1 = &one, .extra2 = &u8_max, }, {
In Documentation/networking/dccp.txt points that request_retries should be greater than 0. So make the extra1 to be &one instead of &zero. Signed-off-by: Wang Weidong <wangweidong1@huawei.com> --- net/dccp/sysctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)