diff mbox

[1/5] python-pygame: Remove wildcards in macros

Message ID 1396979109-10691-1-git-send-email-paul@crapouillou.net
State Rejected
Headers show

Commit Message

Paul Cercueil April 8, 2014, 5:45 p.m. UTC
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 package/python-pygame/python-pygame.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard April 10, 2014, 9:07 p.m. UTC | #1
>>>>> "Paul" == Paul Cercueil <paul@crapouillou.net> writes:

 > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
 > ---
 >  package/python-pygame/python-pygame.mk | 4 ++--
 >  1 file changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/package/python-pygame/python-pygame.mk b/package/python-pygame/python-pygame.mk
 > index d9219b9..b6381a3 100644
 > --- a/package/python-pygame/python-pygame.mk
 > +++ b/package/python-pygame/python-pygame.mk
 > @@ -83,13 +83,13 @@ define PYTHON_PYGAME_CONFIGURE_CMDS
 >  endef
 
 >  define PYTHON_PYGAME_REMOVE_DOC
 > -	rm -rf $(TARGET_DIR)/usr/lib/python*/site-packages/pygame/docs
 > +	rm -rf $(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages/pygame/docs

What's the advantage of this? If pygame starts supporting python3.x then
this breaks.
Thomas Petazzoni April 20, 2014, 9:58 a.m. UTC | #2
Dear Paul Cercueil,

On Tue,  8 Apr 2014 19:45:05 +0200, Paul Cercueil wrote:
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  package/python-pygame/python-pygame.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Following the comment from Peter, and some IRC discussion, I've marked
this patch as Rejected.

Thomas
diff mbox

Patch

diff --git a/package/python-pygame/python-pygame.mk b/package/python-pygame/python-pygame.mk
index d9219b9..b6381a3 100644
--- a/package/python-pygame/python-pygame.mk
+++ b/package/python-pygame/python-pygame.mk
@@ -83,13 +83,13 @@  define PYTHON_PYGAME_CONFIGURE_CMDS
 endef
 
 define PYTHON_PYGAME_REMOVE_DOC
-	rm -rf $(TARGET_DIR)/usr/lib/python*/site-packages/pygame/docs
+	rm -rf $(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages/pygame/docs
 endef
 
 PYTHON_PYGAME_POST_INSTALL_TARGET_HOOKS += PYTHON_PYGAME_REMOVE_DOC
 
 define PYTHON_PYGAME_REMOVE_TESTS
-	rm -rf $(TARGET_DIR)/usr/lib/python*/site-packages/pygame/tests
+	rm -rf $(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages/pygame/tests
 endef
 
 PYTHON_PYGAME_POST_INSTALL_TARGET_HOOKS += PYTHON_PYGAME_REMOVE_TESTS