diff mbox

ext3: explicitly remove inode from orphan list after failed direct io

Message ID 5327493C.7060801@redhat.com
State Not Applicable, archived
Headers show

Commit Message

Eric Sandeen March 17, 2014, 7:13 p.m. UTC
Otherwise non-empty orphan list will be triggered on umount.

This is just an application of commit da1daf by Dmitry Monakhov
to the same code in ext3.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jan Kara March 17, 2014, 7:22 p.m. UTC | #1
On Mon 17-03-14 14:13:00, Eric Sandeen wrote:
> Otherwise non-empty orphan list will be triggered on umount.
> 
> This is just an application of commit da1daf by Dmitry Monakhov
> to the same code in ext3.
  Thanks, I've merged the patch.

							Honza
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
> index 384b6eb..caf4c4a 100644
> --- a/fs/ext3/inode.c
> +++ b/fs/ext3/inode.c
> @@ -1925,6 +1925,8 @@ retry:
>  			 * and pretend the write failed... */
>  			ext3_truncate_failed_direct_write(inode);
>  			ret = PTR_ERR(handle);
> +			if (inode->i_nlink)
> +				ext3_orphan_del(NULL, inode);
>  			goto out;
>  		}
>  		if (inode->i_nlink)
diff mbox

Patch

diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 384b6eb..caf4c4a 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1925,6 +1925,8 @@  retry:
 			 * and pretend the write failed... */
 			ext3_truncate_failed_direct_write(inode);
 			ret = PTR_ERR(handle);
+			if (inode->i_nlink)
+				ext3_orphan_del(NULL, inode);
 			goto out;
 		}
 		if (inode->i_nlink)