Message ID | CAHkwnC99ifVpDJPBnMD+4rsWcykfMf2U4KTrtZRYqpkRVUfy1w@mail.gmail.com |
---|---|
State | Not Applicable |
Headers | show |
On 03/12/2014 01:44 PM, Fabio Porcedda wrote: > - $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\ > + $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS) > $(TARGETS_ROOTFS))),\ Hi Fabio, Thanks for the patch; I confirm it repairs fakeroot fetching. I'll start to use it instead of the reverts and see how it goes. Best regards, V.
On Wed, Mar 12, 2014 at 3:11 PM, Vincent Stehlé <vincent.stehle@freescale.com> wrote: > On 03/12/2014 01:44 PM, Fabio Porcedda wrote: >> >> - $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\ >> + $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS) >> $(TARGETS_ROOTFS))),\ > > > Hi Fabio, > > Thanks for the patch; I confirm it repairs fakeroot fetching. I'll start to > use it instead of the reverts and see how it goes. Great! Thanks for testing it and sorry for the trouble. I will send tomorrow the patch to the mailing list, maybe an improved version because i fear that i need to add TARGETS_ROOTFS in more places. Best regards
On Wed, Mar 12, 2014 at 3:25 PM, Fabio Porcedda <fabio.porcedda@gmail.com> wrote: > On Wed, Mar 12, 2014 at 3:11 PM, Vincent Stehlé > <vincent.stehle@freescale.com> wrote: >> On 03/12/2014 01:44 PM, Fabio Porcedda wrote: >>> >>> - $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\ >>> + $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS) >>> $(TARGETS_ROOTFS))),\ >> >> >> Hi Fabio, >> >> Thanks for the patch; I confirm it repairs fakeroot fetching. I'll start to >> use it instead of the reverts and see how it goes. > > Great! > Thanks for testing it and sorry for the trouble. > I will send tomorrow the patch to the mailing list, maybe an improved > version because i fear that i need to add TARGETS_ROOTFS in more > places. Patch sent: http://patchwork.ozlabs.org/patch/330004/ Regards
diff --git a/Makefile b/Makefile index 481f779..e8e41a4 100644 --- a/Makefile +++ b/Makefile @@ -418,7 +418,7 @@ TARGETS_DIRCLEAN := $(patsubst %,%-dirclean,$(TARGETS)) # variable for each enabled target. # Notice: this only works for newstyle gentargets/autotargets packages TARGETS_HOST_DEPS = $(sort $(filter host-%,$(foreach dep,\ - $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS))),\ + $(addsuffix _DEPENDENCIES,$(call UPPERCASE,$(TARGETS) $(TARGETS_ROOTFS))),\ $($(dep))))) # Host packages can in turn have their own dependencies. Likewise find