Message ID | 20140306170354.GA31372@redhat.com |
---|---|
State | Awaiting Upstream, archived |
Delegated to: | David Miller |
Headers | show |
Hello. On 03/06/2014 08:03 PM, Dave Jones wrote: > Commit 1eb4301867 added an allocation of an skb via brcmu_pkt_buf_get_skb() Please also specify that commit's summary line is parens. > but forgot to free it on one of the error paths. > Cc: Arend van Spriel <arend@broadcom.com> > Signed-off-by: Dave Jones <davej@fedoraproject.org> WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c b/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c index 119ee6eaf1c3..ddaa9efd053d 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c @@ -1948,8 +1948,10 @@ static int brcmf_sdio_txpkt_prep_sg(struct brcmf_sdio *bus, if (pkt_pad == NULL) return -ENOMEM; ret = brcmf_sdio_txpkt_hdalign(bus, pkt_pad); - if (unlikely(ret < 0)) + if (unlikely(ret < 0)) { + kfree_skb(pkt_pad); return ret; + } memcpy(pkt_pad->data, pkt->data + pkt->len - tail_chop, tail_chop);
Commit 1eb4301867 added an allocation of an skb via brcmu_pkt_buf_get_skb() but forgot to free it on one of the error paths. Cc: Arend van Spriel <arend@broadcom.com> Signed-off-by: Dave Jones <davej@fedoraproject.org> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html