| Message ID | 1393110449-12710-1-git-send-email-rjbarnet@rockwellcollins.com |
|---|---|
| State | Accepted |
| Commit | 108952af0a1f60691d4028362512664686267ec9 |
| Headers | show |
>>>>> "Ryan" == Ryan Barnett <ryanbarnett3@gmail.com> writes: > rt-tests is not supported by a uclibc toolchain that does not implement > _pid in struct sigevent. Currently this is all MIPS architectures > in uclibc. > Fixes: > http://autobuild.buildroot.net/results/074/074265602bec4aba6c82d1aee389045e8ad33d4b Committed both, thanks.
Ryan, Peter, All, On 2014-02-23 00:07 +0100, Ryan Barnett spake thusly: > rt-tests is not supported by a uclibc toolchain that does not implement > _pid in struct sigevent. Currently this is all MIPS architectures > in uclibc. > > Fixes: > http://autobuild.buildroot.net/results/074/074265602bec4aba6c82d1aee389045e8ad33d4b > > Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com> > --- > package/rt-tests/Config.in | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in > index 58a88a8..a8cede0 100644 > --- a/package/rt-tests/Config.in > +++ b/package/rt-tests/Config.in > @@ -5,6 +5,9 @@ config BR2_PACKAGE_RT_TESTS > depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD > # no NPTL for these archs > depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc > + # no _tid field in 'struct sigevent' > + depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \ > + BR2_mips64 || BR2_mips64el) Gah! This is not correct Kconfig syntax and breaks: $ make menuconfig [...] package/rt-tests/Config.in:10: syntax error package/rt-tests/Config.in:9: invalid option package/rt-tests/Config.in:36: syntax error package/rt-tests/Config.in:35: invalid option make[1]: *** [oldconfig] Error 1 Peter, can we revert this change until we have a proper fix, please? Ryan, what were you trying to do here? Why can you use something like (variable abbreviated for clarity): depends on ! ( UCLIBC && ( mips || mipsel || mips64 || mips64el ) ) > help > Set of utilities for testing the real-time behaviour of a > Linux system. > @@ -27,3 +30,7 @@ comment "rt-tests needs a toolchain w/ threads" > depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD > depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc > depends on !BR2_TOOLCHAIN_HAS_THREADS > + > +comment "rt-tests needs an (e)glibc toolchain" > + depends on BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \ > + BR2_mips64 || BR2_mips64el) Ditto. Regards, Yann E. MORIN.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > Gah! This is not correct Kconfig syntax and breaks: > $ make menuconfig > [...] > package/rt-tests/Config.in:10: syntax error > package/rt-tests/Config.in:9: invalid option > package/rt-tests/Config.in:36: syntax error > package/rt-tests/Config.in:35: invalid option > make[1]: *** [oldconfig] Error 1 > Peter, can we revert this change until we have a proper fix, please? Argh, indeed. > Ryan, what were you trying to do here? Why can you use something like > (variable abbreviated for clarity): > depends on ! ( UCLIBC && ( mips || mipsel || mips64 || mips64el ) ) Sorry, my fault. Ryan's first version wasn't correct, so I suggested something like the 2nd approach (but never tested it).
diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in index 58a88a8..a8cede0 100644 --- a/package/rt-tests/Config.in +++ b/package/rt-tests/Config.in @@ -5,6 +5,9 @@ config BR2_PACKAGE_RT_TESTS depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD # no NPTL for these archs depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc + # no _tid field in 'struct sigevent' + depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \ + BR2_mips64 || BR2_mips64el) help Set of utilities for testing the real-time behaviour of a Linux system. @@ -27,3 +30,7 @@ comment "rt-tests needs a toolchain w/ threads" depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc depends on !BR2_TOOLCHAIN_HAS_THREADS + +comment "rt-tests needs an (e)glibc toolchain" + depends on BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \ + BR2_mips64 || BR2_mips64el)
rt-tests is not supported by a uclibc toolchain that does not implement _pid in struct sigevent. Currently this is all MIPS architectures in uclibc. Fixes: http://autobuild.buildroot.net/results/074/074265602bec4aba6c82d1aee389045e8ad33d4b Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com> --- package/rt-tests/Config.in | 7 +++++++ 1 file changed, 7 insertions(+)