Message ID | 1392345043-12208-4-git-send-email-yangyingliang@huawei.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Fri, 2014-02-14 at 10:30 +0800, Yang Yingliang wrote: > Replace some magic numbers which describe states of GE model > loss generator with enumerate. [...] The name GOOD_STATE should also be used in get_loss_clg() where clgstate::state is initialised. Ben.
On 2014/2/16 20:44, Ben Hutchings wrote: > On Fri, 2014-02-14 at 10:30 +0800, Yang Yingliang wrote: >> Replace some magic numbers which describe states of GE model >> loss generator with enumerate. > [...] > > The name GOOD_STATE should also be used in get_loss_clg() where > clgstate::state is initialised. > > Ben. > OK, thanks! Regards, Yang -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 4a5eb28..4fced67 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -117,6 +117,11 @@ struct netem_sched_data { LOST_IN_BURST_PERIOD, } _4_state_model; + enum { + GOOD_STATE = 1, + BAD_STATE, + } GE_state_model; + /* Correlated Loss Generation models */ struct clgstate { /* state of the Markov chain */ @@ -272,15 +277,15 @@ static bool loss_gilb_ell(struct netem_sched_data *q) struct clgstate *clg = &q->clg; switch (clg->state) { - case 1: + case GOOD_STATE: if (prandom_u32() < clg->a1) - clg->state = 2; + clg->state = BAD_STATE; if (prandom_u32() < clg->a4) return true; break; - case 2: + case BAD_STATE: if (prandom_u32() < clg->a2) - clg->state = 1; + clg->state = GOOD_STATE; if (prandom_u32() > clg->a3) return true; }
Replace some magic numbers which describe states of GE model loss generator with enumerate. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- net/sched/sch_netem.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)