| Message ID | 1392265339-14841-1-git-send-email-liujunliang_ljl@163.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: liujunliang_ljl@163.com Date: Thu, 13 Feb 2014 12:22:19 +0800 > From: Liu Junliang <liujunliang_ljl@163.com> > > > Signed-off-by: Liu Junliang <liujunliang_ljl@163.com> I think it's more canonical to specify no default at all. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Date: Fri, 14 Feb 2014 03:38:17 +0300 > Hello. > > On 02/14/2014 02:32 AM, David Miller wrote: > >>> From: Liu Junliang <liujunliang_ljl@163.com> > >>> Signed-off-by: Liu Junliang <liujunliang_ljl@163.com> > >> I think it's more canonical to specify no default at all. > > That's what he did, no? Indeed, my bad, patch applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 02/14/2014 02:32 AM, David Miller wrote: >> From: Liu Junliang <liujunliang_ljl@163.com> >> Signed-off-by: Liu Junliang <liujunliang_ljl@163.com> > I think it's more canonical to specify no default at all. That's what he did, no? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear David : Thanks all the same. 2014-02-14 liujunliang_ljl 发件人： David Miller 发送时间： 2014-02-14 07:42:24 收件人： sergei.shtylyov 抄送： liujunliang_ljl; thierry.reding; horms; joe; romieu; gregkh; netdev; linux-usb; linux-kernel; sunhecheng 主题： Re: [PATCH] Fix Default to 'y' for SR9800 Device Driver, settingto 'n' From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Date: Fri, 14 Feb 2014 03:38:17 +0300 > Hello. > > On 02/14/2014 02:32 AM, David Miller wrote: > >>> From: Liu Junliang <liujunliang_ljl@163.com> > >>> Signed-off-by: Liu Junliang <liujunliang_ljl@163.com> > >> I think it's more canonical to specify no default at all. > > That's what he did, no? Indeed, my bad, patch applied, thanks! .
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index 2551bf6..82df7c3 100644 --- a/drivers/net/usb/Kconfig +++ b/drivers/net/usb/Kconfig @@ -295,7 +295,6 @@ config USB_NET_SR9800 tristate "CoreChip-sz SR9800 based USB 2.0 10/100 ethernet devices" depends on USB_USBNET select CRC32 - default y ---help--- Say Y if you want to use one of the following 100Mbps USB Ethernet device based on the CoreChip-sz SR9800 chip.