Message ID | 20090623150414.22490.14888.stgit@localhost |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
On Tue, 2009-06-23 at 17:04 +0200, Jesper Dangaard Brouer wrote: > The sunrpc module uses rcu_call() thus it should use rcu_barrier() on > module unload. > > Have not verified that the possibility for new call_rcu() callbacks > has been disabled. As a hint for checking, the functions calling > call_rcu() (unx_destroy_cred and generic_destroy_cred) are > registered as crdestroy function pointer in struct rpc_credops. > > Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk> > --- > > net/sunrpc/sunrpc_syms.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c > index 843629f..adaa819 100644 > --- a/net/sunrpc/sunrpc_syms.c > +++ b/net/sunrpc/sunrpc_syms.c > @@ -66,6 +66,7 @@ cleanup_sunrpc(void) > #ifdef CONFIG_PROC_FS > rpc_proc_exit(); > #endif > + rcu_barrier(); /* Wait for completion of call_rcu()'s */ > } > MODULE_LICENSE("GPL"); > module_init(init_sunrpc); > Acked-by: Trond Myklebust <Trond.Myklebust@netapp.com>
diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c index 843629f..adaa819 100644 --- a/net/sunrpc/sunrpc_syms.c +++ b/net/sunrpc/sunrpc_syms.c @@ -66,6 +66,7 @@ cleanup_sunrpc(void) #ifdef CONFIG_PROC_FS rpc_proc_exit(); #endif + rcu_barrier(); /* Wait for completion of call_rcu()'s */ } MODULE_LICENSE("GPL"); module_init(init_sunrpc);
The sunrpc module uses rcu_call() thus it should use rcu_barrier() on module unload. Have not verified that the possibility for new call_rcu() callbacks has been disabled. As a hint for checking, the functions calling call_rcu() (unx_destroy_cred and generic_destroy_cred) are registered as crdestroy function pointer in struct rpc_credops. Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk> --- net/sunrpc/sunrpc_syms.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html