| Message ID | 1391388475-14410-1-git-send-email-maxime.hadjinlian@gmail.com |
|---|---|
| State | Accepted |
| Commit | 3bcb7e74be71990e7c88facd54d6b90d3d04d681 |
| Headers | show |
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes: > Try to clarify how the wrapper passes arguments and why. > This is mainly because the output you can see when you build, does not > reflect what is invoked by the wrapper. > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> This patch is quite hard to read as you rewrapped the entire paragraph, but OK - look good to me. Committed, thanks.
Hi Peter, On Mon, Feb 3, 2014 at 9:25 AM, Peter Korsgaard <jacmet@uclibc.org> wrote: >>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes: > > > Try to clarify how the wrapper passes arguments and why. > > This is mainly because the output you can see when you build, does not > > reflect what is invoked by the wrapper. > > > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > > This patch is quite hard to read as you rewrapped the entire paragraph, > but OK - look good to me. Committed, thanks. How should I have done it ? I was adding a few words, then, I rewrapped the whole things using gq in vim. Should I have only wrapped by hand ? > > -- > Bye, Peter Korsgaard
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes: Hi, >> This patch is quite hard to read as you rewrapped the entire paragraph, >> but OK - look good to me. Committed, thanks. > How should I have done it ? I was adding a few words, then, I > rewrapped the whole things using gq in vim. > Should I have only wrapped by hand ? I would have preferred to only wrap from the line where you added text to the end of the section, just to make the diff smaller / more readable, but it's not a big deal.
diff --git a/docs/manual/customize-toolchain.txt b/docs/manual/customize-toolchain.txt index 31c9140..4f3fe23 100644 --- a/docs/manual/customize-toolchain.txt +++ b/docs/manual/customize-toolchain.txt @@ -17,9 +17,10 @@ generate it. It also requires to set the Buildroot settings according to the toolchain ones (see xref:external-toolchain-backend[]). -When using an external toolchain, Buildroot generates a wrapper program, that -passes the appropriate options (according to the configuration) to the -external toolchain programs. In case you need to debug this wrapper, you can +When using an external toolchain, Buildroot generates a wrapper program, +that transparently passes the appropriate options (according to the +configuration) to the external toolchain programs. In case you need to +debug this wrapper to check exactly what arguments are passed, you can set the environment variable BR_DEBUG_WRAPPER to either one of: * +0+, empty or not set: no debug
Try to clarify how the wrapper passes arguments and why. This is mainly because the output you can see when you build, does not reflect what is invoked by the wrapper. Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> --- docs/manual/customize-toolchain.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)