| Message ID | 200906190011.28320.david-b@pacbell.net |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: David Brownell <david-b@pacbell.net> Date: Fri, 19 Jun 2009 00:11:28 -0700 > From: David Brownell <dbrownell@users.sourceforge.net> > > The host-side CDC subset driver is binding more specifically > than it should ... only to PXA 210/25x/26x Linux-USB gadgets. > > Loosen that restriction to match the gadget driver itself. > This helps various PXA 27x and PXA 3xx devices be happier > when talking to Linux hosts; and a few other gadgets too. > > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> > Tested-by: Aric D. Blumer <aric@sdgsystems.com> > --- > Appropriate for -stable ... behaves like a protocol bug. Applied and queued up for -stable. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: David Miller <davem@davemloft.net> Date: Fri, 19 Jun 2009 00:24:03 -0700 (PDT) > From: David Brownell <david-b@pacbell.net> > Date: Fri, 19 Jun 2009 00:11:28 -0700 > >> From: David Brownell <dbrownell@users.sourceforge.net> >> >> The host-side CDC subset driver is binding more specifically >> than it should ... only to PXA 210/25x/26x Linux-USB gadgets. >> >> Loosen that restriction to match the gadget driver itself. >> This helps various PXA 27x and PXA 3xx devices be happier >> when talking to Linux hosts; and a few other gadgets too. >> >> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> >> Tested-by: Aric D. Blumer <aric@sdgsystems.com> >> --- >> Appropriate for -stable ... behaves like a protocol bug. > > Applied and queued up for -stable. David this doesn't even compile: CC [M] drivers/net/usb/cdc_subset.o drivers/net/usb/cdc_subset.c:313:32: error: macro "USB_DEVICE_VER" requires 4 arguments, but only 2 given drivers/net/usb/cdc_subset.c:313: error: 'USB_DEVICE_VER' undeclared here (not in a function) There is absolutely no excuse for this, really. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 19 June 2009, David Miller wrote: > David this doesn't even compile: Sorry, my bad. Fixed in the followup. > CC [M] drivers/net/usb/cdc_subset.o > drivers/net/usb/cdc_subset.c:313:32: error: macro "USB_DEVICE_VER" requires 4 arguments, but only 2 given > drivers/net/usb/cdc_subset.c:313: error: 'USB_DEVICE_VER' undeclared here (not in a function) > > There is absolutely no excuse for this, really. Sure there is: sent it out too soon, before the compile test! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/net/usb/cdc_subset.c +++ b/drivers/net/usb/cdc_subset.c @@ -307,9 +307,10 @@ static const struct usb_device_id produc USB_DEVICE (0x1286, 0x8001), // "blob" bootloader .driver_info = (unsigned long) &blob_info, }, { - // Linux Ethernet/RNDIS gadget on pxa210/25x/26x, second config - // e.g. Gumstix, current OpenZaurus, ... - USB_DEVICE_VER (0x0525, 0xa4a2, 0x0203, 0x0203), + // Linux Ethernet/RNDIS gadget, mostly on PXA, second config + // e.g. Gumstix, current OpenZaurus, ... or anything else + // that just enables this gadget option. + USB_DEVICE_VER (0x0525, 0xa4a2), .driver_info = (unsigned long) &linuxdev_info, }, #endif